Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick patch from V8 upstream that fixes instanceof problem #7638

Closed
wants to merge 5 commits into from
Closed

Cherry-pick patch from V8 upstream that fixes instanceof problem #7638

wants to merge 5 commits into from

Commits on Jul 21, 2016

  1. deps: cherry-pick 2aa070be from V8 upstream 

    Original commit message:

    InstanceOfStub incorrectly interprets the hole as a prototype.

    Repair this to match what the runtime correctly does, by first
    checking if the function is a constructor before we access the
    prototype.

    R=verwaest@chromium.org

    BUG=

    Committed: https://crrev.com/2aa070be4fd2960df98905b254f12ed801ef26cd

    Cr-Commit-Position: refs/heads/master@{nodejs#34863}

This fixes the behavior of instanceof when the second parameter is not a
constructor.

Fixes: nodejs#7592
    @fhinkel
    fhinkel committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    ca51390 View commit details
    Browse the repository at this point in the history

  2. deps: cherry-pick 3a903c4 for PPC from V8 upstream 

    Original commit message:

    PPC: InstanceOfStub incorrectly interprets the hole as a prototype.
    Port 2aa070b

    Original commit message:
        Repair this to match what the runtime correctly does,
        by first checking if the function is a constructor
        before we access the prototype.

    R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
    michael_dawson@ca.ibm.com

    BUG=

    Review URL: https://codereview.chromium.org/1811013002

    Cr-Commit-Position: refs/heads/master@{nodejs#34869}

Fixes: nodejs#7592 for PPC
    @fhinkel
    fhinkel committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    e06e255 View commit details
    Browse the repository at this point in the history

  3. deps: cherry-pick 5b5d24b for X87 from V8 upstream 

    Original commit message:

    port 2aa070b (r34863)

    original commit message:
        Repair this to match what the runtime correctly does,
        by first checking if the function is a constructor
        before we access the prototype.

    BUG=

    Review URL: https://codereview.chromium.org/1809333002

    Cr-Commit-Position: refs/heads/master@{nodejs#34880}

Fixes: nodejs#7592 for X87
    @fhinkel
    fhinkel committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    f007c0a View commit details
    Browse the repository at this point in the history

  4. test: add regression test for instanceof 

    See issue nodejs#7592.
    @fhinkel
    fhinkel committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    ef9092b View commit details
    Browse the repository at this point in the history

  5. deps: bump V8 patchlevel for instanceof cherry-picks

    @fhinkel
    fhinkel committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    8261c9f View commit details
    Browse the repository at this point in the history