Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update node.js references in api docs #750

Closed
wants to merge 2 commits into from
Closed

doc: update node.js references in api docs #750

wants to merge 2 commits into from

Conversation

bnoordhuis
Copy link
Member

Fixes: iojs#740

R=@cjihrig?

@bnoordhuis bnoordhuis mentioned this pull request Feb 7, 2015
Closed
@rvagg
Copy link
Member

rvagg commented Feb 7, 2015

rad

cjihrig
cjihrig reviewed Feb 7, 2015
View reviewed changes
doc/api/child_process.markdown
processes. In addition to having all the methods in a normal ChildProcess
instance, the returned object has a communication channel built-in. See
`child.send(message, [sendHandle])` for details.

These child Nodes are still whole new instances of V8. Assume at least 30ms
startup and 10mb memory for each new Node. That is, you cannot create many
These child io.js's are still whole new instances of V8. Assume at least 30ms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to These child io.js processes....

@cjihrig
Copy link
Contributor

cjihrig commented Feb 7, 2015

A couple tiny nits, but LGTM.

@bnoordhuis
Copy link
Member Author

I was wondering about that. Is it still 'an $x' when $x is a product name?

@rvagg
Copy link
Member

rvagg commented Feb 7, 2015

You wouldn't say "a iPhone"

@cjihrig
Copy link
Contributor

cjihrig commented Feb 7, 2015

AFAIK, yes it's still an.

@bnoordhuis
Copy link
Member Author

Okay, updated. PTAL.

bnoordhuis added a commit that referenced this pull request Feb 7, 2015
@bnoordhuis @cjihrig
doc: update node.js references in api docs
789bbb9 
Fixes: #740
PR-URL: #750
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bnoordhuis added a commit that referenced this pull request Feb 7, 2015
@bnoordhuis @cjihrig
doc: update antiquated process.versions output
90d2b35 
PR-URL: #750
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@cjihrig
Copy link
Contributor

cjihrig commented Feb 7, 2015

Thanks Ben. Landed in 789bbb9 and 90d2b35

@cjihrig cjihrig closed this Feb 7, 2015
@bnoordhuis bnoordhuis deleted the fix-issue-740 branch February 9, 2015 10:54
@targos targos mentioned this pull request Feb 10, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @rvagg @cjihrig