buffer: fix creating from zero-length ArrayBuffer #7176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: 85ab4a5
nodejs-github-bot
added
the
buffer
|
LGTM with CI: https://ci.nodejs.org/job/node-test-commit/3664/ |
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
|
Landed in 0e9e149, thanks! |
addaleax
pushed a commit
that referenced
this pull request
Jun 13, 2016
Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: 85ab4a5 PR-URL: #7176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
|
This is not landing cleanly on v6.x. Going to hold off for now. @RReverser interested in opening a backport PR targeting the v6.x branch? |
|
@evanlucas Sure. Can I read about what are the requirements to such PR? (description / title / whatever / ...) As far as I understand, it should be basically just a rebase? |
2 tasks
|
@RReverser it is really just a rebase. Making keep the same title in the PR, but add |
3 tasks
evanlucas
pushed a commit
that referenced
this pull request
Jul 18, 2016
Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: 85ab4a5 PR-URL: #7176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
evanlucas
pushed a commit
that referenced
this pull request
Jul 20, 2016
Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: 85ab4a5 PR-URL: #7176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
evanlucas
added a commit
that referenced
this pull request
Jul 21, 2016
Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782
evanlucas
added a commit
that referenced
this pull request
Jul 21, 2016
Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782
evanlucas
added a commit
that referenced
this pull request
Jul 21, 2016
Notable changes: * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602 * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176 * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531 * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638 * **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794 * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641 PR-URL: #7782
lukesampson
pushed a commit
to ScoopInstaller/Scoop
that referenced
this pull request
Jul 24, 2016
### Notable changes * **buffer**: * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) [#7602](nodejs/node#7602) * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) [#7176](nodejs/node#7176) * **deps**: * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) [#7531](nodejs/node#7531) * Backport V8 instanceof bugfix (Franziska Hinkelmann) [#7638](nodejs/node#7638) * **repl**: Fix issue with function redeclaration. (Prince J Wesley) [#7794](nodejs/node#7794) * **util**: Fix inspecting of boxed symbols. (Anna Henningsen) [#7641](nodejs/node#7641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
buffer
Description of change
Fixes regression introduced in 85ab4a5 where creating a new Buffer from an empty ArrayBuffer would fail.
Initially found in #6893.
cc @trevnorris @addaleax @ChALkeR