deps: upgrade npm to 3.9.5 #7139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
npm
|
Tests pass, lgtm. landing tomorrow unless anything arises. |
|
LGTM |
|
landed in 843d58f |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 6, 2016
PR-URL: #7139 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
PR-URL: #7139 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
evanlucas
added a commit
that referenced
this pull request
Jun 16, 2016
Notable changes:
* **http**:
- When maybeReadMore kicks in on a first bytes of incoming data, the
req.read(0) will be invoked and the `req._consuming` will be set to
true. This seemingly harmless property leads to a dire consequences:
the server won't call `req._dump()` and the whole HTTP/1.1 pipeline
will hang (single connection). (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
Merged
evanlucas
added a commit
that referenced
this pull request
Jun 16, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
#7323
evanlucas
added a commit
that referenced
this pull request
Jun 17, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
#7323
evanlucas
added a commit
that referenced
this pull request
Jun 17, 2016
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
PR-URL: #7323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
depsDescription of change
Hey y'all!
This is a fairly small release that includes two npm versions. Nothing particularly worth noting about these other than some documentation updates/test tweaks, except that this includes @thealphanerd's patches to make sure
.nyc_outputdidn't get included in the release tarball, which was done as a one-off point release.Changelogs:
3.9.43.9.5r: @iarna
r: @thealphanerd
r: @Fishrock123