Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove non-incremental common.PORT changes #7055

Closed
wants to merge 1 commit into from
Closed

test: remove non-incremental common.PORT changes #7055

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 29, 2016 •
edited
Loading

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Remove uses of common.PORT + 1337 where common.PORT suffices.

Refs: #6990

@Trott
test: remove non-incremental common.PORT changes
9122028 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

Refs: nodejs#6990
@Trott Trott added debugger test Issues and PRs related to the tests. labels May 29, 2016
@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented May 30, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jun 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2894/

Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2016
@Trott
test: remove non-incremental common.PORT changes
85da963 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: nodejs#7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: nodejs#6990
@Trott
Copy link
Member Author

Trott commented Jun 2, 2016

Landed in 85da963

@Trott Trott closed this Jun 2, 2016
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@Trott @rvagg
test: remove non-incremental common.PORT changes
8b720c4 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Trott
test: remove non-incremental common.PORT changes
97e651d 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
test: remove non-incremental common.PORT changes
ef8cb6a 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: remove non-incremental common.PORT changes
ff9fedc 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: remove non-incremental common.PORT changes
6a85acc 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: remove non-incremental common.PORT changes
5b1f546 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
@Trott Trott deleted the say-no branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @bnoordhuis @cjihrig @MylesBorins