Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-child-process-fork-net more robust #7033

Closed
wants to merge 1 commit into from
Closed

test: make test-child-process-fork-net more robust #7033

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 28, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test child_process

Description of change

test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

Example failure: https://ci.nodejs.org/job/node-test-commit-freebsd/2679/nodes=freebsd10-64/consoleFull

not ok 55 parallel/test-child-process-fork-net
# events.js:160
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: listen EADDRINUSE :::12347
#     at Object.exports._errnoException (util.js:1007:11)
#     at exports._exceptionWithHostPort (util.js:1030:20)
#     at Server._listen2 (net.js:1253:14)
#     at listen (net.js:1289:10)
#     at Server.listen (net.js:1385:5)
#     at testSocket (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-child-process-fork-net.js:146:12)
#     at /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-child-process-fork-net.js:172:7
#     at ChildProcess.messageHandlers (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-child-process-fork-net.js:117:9)
#     at emitTwo (events.js:106:13)
#     at ChildProcess.emit (events.js:191:7)
# PARENT: server listening
# CHILD: server listening
# PARENT: got connection
# PARENT: got connection
# CHILD: got connection
# PARENT: got connection
# CLIENT: connected
# CLIENT: connected
# CLIENT: connected
# CLIENT: connected
# CLIENT: closed
# CLIENT: closed
# CLIENT: closed
# CLIENT: closed
# PARENT: server closed
  ---
  duration_ms: 0.448

@mscdex @nodejs/testing

@Trott
test: make test-child-process-fork-net more robust
affc5fe 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.
@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. labels May 28, 2016
@mscdex
Copy link
Contributor

mscdex commented May 28, 2016 •
edited
Loading

LGTM if CI is ok: https://ci.nodejs.org/job/node-stress-single-test/746/ https://ci.nodejs.org/job/node-stress-single-test/747/

@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented May 28, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented May 31, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2885/

@Trott
Copy link
Member Author

Trott commented Jun 1, 2016

Windows buildbot problems on CI. Re-running on Windows only, everything else (so far) is green: https://ci.nodejs.org/job/node-test-commit-windows-fanned/2809/

Trott added a commit to Trott/io.js that referenced this pull request Jun 1, 2016
@Trott
test: make test-child-process-fork-net more robust
e4b78c6 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: nodejs#7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Jun 1, 2016

Landed in e4b78c6

@Trott Trott closed this Jun 1, 2016
Fishrock123 pushed a commit that referenced this pull request Jun 1, 2016
@Trott @Fishrock123
test: make test-child-process-fork-net more robust
ef7f016 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@Trott @rvagg
test: make test-child-process-fork-net more robust
81a9f96 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@Trott lts?

@Trott
Copy link
Member Author

Trott commented Jul 11, 2016

@thealphanerd If it lands cleanly, yes.

MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Trott
test: make test-child-process-fork-net more robust
e0dc5a6 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
test: make test-child-process-fork-net more robust
3ffbb27 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: make test-child-process-fork-net more robust
5dca3d4 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: make test-child-process-fork-net more robust
3299ad3 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: make test-child-process-fork-net more robust
042e858 
test-child-process-fork-net will sometimes fail in CI with EADDRINUSE
because an earlier test failed to free common.PORT. Have the operating
system provide an available port instead.

PR-URL: #7033
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott deleted the forknet branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @mscdex @bnoordhuis @cjihrig @addaleax @MylesBorins