Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for tls #7018

Closed
wants to merge 25 commits into from
Closed

doc: add added: information for tls #7018

wants to merge 25 commits into from

Conversation

italoacasas
Copy link
Contributor

@italoacasas italoacasas commented May 27, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for tls

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 27, 2016
@addaleax addaleax added wip Issues and PRs that are still a work in progress. tls Issues and PRs related to the tls subsystem. labels May 27, 2016
@@ -134,7 +134,6 @@ threshold is exceeded. The limits are configurable:
requests. Defaults to `3`.
* `tls.CLIENT_RENEG_WINDOW` {number} Specifies the time renegotiation window
in seconds. Defaults to `600` (10 minutes).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary whitespace change

@jasnell
Copy link
Member

jasnell commented May 27, 2016

LGTM with a nit

@@ -1019,6 +1024,9 @@ openssl s_client -connect 127.0.0.1:8000
```

## tls.getCiphers()
<!--YAML
v0.10.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have added: before it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh.. completely overlooked that ;-) good catch.

@jasnell
Copy link
Member

jasnell commented May 27, 2016

(correction, LGTM with nits addressed ;-) ...)

@italoacasas
Copy link
Contributor Author

@addaleax this is done.

@@ -473,7 +523,9 @@ https://www.openssl.org/docs/manmaster/ssl/SSL_CIPHER_get_name.html for more
information.

### tlsSocket.getEphemeralKeyInfo()

<!--YAML
added: v5.0.0-rc.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release candidates don’t really count, you can just set this to v5.0.0

@addaleax addaleax removed the wip Issues and PRs that are still a work in progress. label May 28, 2016

Returns a `Buffer` instance holding the keys currently used for
encryption/decryption of the [TLS Session Tickets][]

### server.listen(port[, hostname][, callback])
<!-- YAML
added: v0.11.3
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inherited from net.Server?

@italoacasas
Copy link
Contributor Author

I'm going to review this entire module again.

@addaleax
Copy link
Member

LGTM

@addaleax
Copy link
Member

Landed in c2e6078 with minor whitespace fixups, thanks!

@addaleax addaleax closed this Jun 23, 2016
addaleax pushed a commit that referenced this pull request Jun 23, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
Ref: nodejs#6578
PR-URL: nodejs#7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants