Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udp: use libuv API to get file descriptor #6908

Merged
merged 1 commit into from
May 23, 2016
Merged

udp: use libuv API to get file descriptor #6908

merged 1 commit into from
May 23, 2016
+4 −2

Conversation

saghul
Copy link
Member

@saghul saghul commented May 20, 2016

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 20, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label May 20, 2016
@bnoordhuis
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented May 21, 2016

LGTM... would be ideal if there was some way to actually test this tho so we don't get regressions later

@cjihrig
Copy link
Contributor

cjihrig commented May 21, 2016

LGTM

@saghul
Copy link
Member Author

saghul commented May 21, 2016

@jasnell I'm open to suggestions, but how do we test that the way to obtain that value has changed in C++ ? FWIW, before this change Node was relying on libuv internals, which can be seen as "broken" already, because we could've changed it without notice.

@jasnell
Copy link
Member

jasnell commented May 22, 2016

;-) I didn't say I had any good suggestions for a test ;-) I'm fine with this landing as is, but if someone can come up with a way of testing then +1

@saghul
udp: use libuv API to get file descriptor
3ef2eb2 
Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@saghul saghul merged commit 3ef2eb2 into nodejs:master May 23, 2016
@saghul saghul deleted the udp-fileno branch May 23, 2016 21:20
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
@saghul @Fishrock123
udp: use libuv API to get file descriptor
feb976f 
Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@saghul @rvagg
udp: use libuv API to get file descriptor
36ed4a2 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
@MylesBorins
Copy link
Contributor

@saghul is it safe to assume that this will be neccessary if we want to backport libuv 1.9? Not entirely sure if this should land or not either way

@saghul
Copy link
Member Author

saghul commented Jun 3, 2016

I'd land it because it poses 0 risk and it makes process.std*._handle.fd
always return the right thing.
On Jun 3, 2016 02:33, "Myles Borins" notifications@github.com wrote:

@saghul https://github.com/saghul is it safe to assume that this will
be neccessary if we want to backport libuv 1.9? Not entirely sure if this
should land or not either way

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6908 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AATYGI0aeG1HE4S4xGdPzO_HtqIEWxXPks5qH4RmgaJpZM4IjmbB
.

@saghul saghul mentioned this pull request Jun 3, 2016
Closed
4 tasks
saghul added a commit to saghul/node that referenced this pull request Jul 11, 2016
@saghul
udp: use libuv API to get file descriptor
13103c2 
Refs: nodejs#6838
PR-URL: nodejs#6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@saghul
udp: use libuv API to get file descriptor
9946b56 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@saghul
udp: use libuv API to get file descriptor
6c1904b 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@saghul
udp: use libuv API to get file descriptor
8a87ef3 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@saghul
udp: use libuv API to get file descriptor
973abab 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@saghul
udp: use libuv API to get file descriptor
a1719a9 
Refs: #6838
PR-URL: #6908
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@saghul @bnoordhuis @jasnell @cjihrig @MylesBorins @trevnorris @mscdex @nodejs-github-bot