Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for assert #6688

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for assert #6688

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 11, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc assert

Description of change

Ref: #6578

@Trott Trott added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels May 11, 2016
@sam-github sam-github mentioned this pull request May 11, 2016
Closed
36 tasks
@claudiorodriguez
Copy link
Contributor

LGTM

3 similar comments
@jasnell
Copy link
Member

jasnell commented May 11, 2016

LGTM

@r-52
Copy link
Contributor

r-52 commented May 11, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented May 13, 2016

Ci: https://ci.nodejs.org/job/node-test-commit/3317/

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
@Trott
doc: add added: information for assert
f52b2f1 
PR-URL: nodejs#6688
Ref: nodejs#6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented May 13, 2016

Landed in f52b2f1

@Trott Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@Trott @evanlucas
doc: add added: information for assert
b4fb95e 
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@Trott @addaleax
doc: add added: information for assert
fcc01d3 
PR-URL: nodejs#6688
Ref: nodejs#6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: add added: information for assert
c645b6d 
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: add added: information for assert
bcee4a5 
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: add added: information for assert
a0ebd1e 
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: add added: information for assert
e52b2b0 
PR-URL: #6688
Ref: #6578
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott deleted the assertiology branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @claudiorodriguez @jasnell @r-52 @addaleax @MylesBorins