Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,win: skip addons/load-long-path on WOW64 #6675

Closed
wants to merge 0 commits into from
Closed

test,win: skip addons/load-long-path on WOW64 #6675

wants to merge 0 commits into from

Conversation

orangemocha
Copy link
Contributor

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

test,win

Description of change

This test fails on WOW64 because of a bug in the OS, and there is
no acceptable wokaround.

Ref: #3667

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 10, 2016
@Fishrock123
Copy link
Contributor

What kind of system is WOW64?

@Fishrock123 Fishrock123 added the windows Issues and PRs related to the Windows platform. label May 10, 2016
@bnoordhuis
Copy link
Member

LGTM although it's more commonly spelled as "WoW64", I think?

@Fishrock123 Windows 32 bits on a Windows 64 bits host.

@orangemocha
Copy link
Contributor Author

I went with the official spelling by Microsoft, I can change it if you feel strongly about it.

https://msdn.microsoft.com/en-us/library/windows/desktop/aa384274(v=vs.85).aspx

C:\>dir /b %windir%\*wow64
SysWOW64

@bnoordhuis
Copy link
Member

No strong feelings.

@orangemocha
Copy link
Contributor Author

I'll wait for #6697 to land and adopt the new skip syntax.

@addaleax
Copy link
Member

@orangemocha #6697 has landed, you should be able to use the new syntax here.

@orangemocha
Copy link
Contributor Author

Updated, thanks!

@cjihrig
Copy link
Contributor

cjihrig commented May 25, 2016

LGTM

@orangemocha
Copy link
Contributor Author

https://ci.nodejs.org/job/node-test-pull-request/2806/

@orangemocha
Copy link
Contributor Author

I am confident that the CI failures on ARM are unrelated to this change. /cc @nodejs/testing https://ci.nodejs.org/job/node-test-binary-arm/2285/RUN_SUBSET=6,label=pi1-raspbian-wheezy/

Landing shortly.

orangemocha added a commit that referenced this pull request May 27, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
6e2ae8a 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
@orangemocha @Fishrock123
test,win: skip addons/load-long-path on WOW64
5729993 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: nodejs#3667

PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@orangemocha @rvagg
test,win: skip addons/load-long-path on WOW64
ea287fc 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Jul 4, 2016

@orangemocha could this be backported? Still seeing this on 4.4.7.

orangemocha added a commit to JaneaSystems/node that referenced this pull request Jul 5, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
8b4c557 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: nodejs#3667

PR-URL: nodejs#6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@orangemocha orangemocha mentioned this pull request Jul 5, 2016
Merged
2 tasks
@orangemocha
Copy link
Contributor Author

@gibm : I opened #7537 to backport it.

orangemocha added a commit that referenced this pull request Jul 8, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
350e8c6 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
d5a4a1f 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
279f3b3 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
84b8061 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@orangemocha
test,win: skip addons/load-long-path on WOW64
e544b1c 
This test fails on WOW64 because of a bug in the OS, and there is
no acceptable workaround.

Ref: #3667

PR-URL: #6675
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@orangemocha @Fishrock123 @bnoordhuis @addaleax @cjihrig @gibfahn @nodejs-github-bot