New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix tools/doc/addon-verify.js regression (and more) #6652

Merged

bnoordhuis merged 4 commits into nodejs:master from bnoordhuis:fix-doc-addons

May 10, 2016

Member

bnoordhuis commented May 9, 2016 •

edited

Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/2546/

bnoordhuis added doc build test lts-watch-v4.x labels

bnoordhuis mentioned this pull request

tools: update marked dependency #6396

Closed

2 tasks

Member

addaleax commented May 9, 2016

Tiniest of nits: In the last commit’s message, the quotes are mismatched. 😉

LGTM!

Member Author

bnoordhuis commented May 9, 2016

Looks like the Windows buildbots are having network connectivity issues...

Member Author

bnoordhuis commented May 10, 2016

New CI: https://ci.nodejs.org/job/node-test-pull-request/2556/

bnoordhuis and others added 4 commits

May 10, 2016 17:10


          test: build addons with V8_DEPRECATION_WARNINGS=1

f644368

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>


          doc: fix deprecation warnings in addon examples

2c75a6b

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>


          build,test: fix build-addons dependency chain

0ea4855

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>


          tools: fix tools/doc/addon-verify.js regression

4f925dd

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: nodejs#6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis force-pushed the fix-doc-addons branch from a0799aa to 4f925dd Compare

May 10, 2016 17:02

bnoordhuis closed this

bnoordhuis deleted the fix-doc-addons branch

May 10, 2016 17:02

bnoordhuis merged commit 4f925dd into nodejs:master

Member Author

bnoordhuis commented May 10, 2016

Landed with commit log amended. :-)

Release people: commit 4f925dd depends on #6396, the other commits should cherry-pick cleanly.

evanlucas pushed a commit that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

26805c9

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas pushed a commit that referenced this pull request


          build,test: fix build-addons dependency chain

6eed6a3

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

evanlucas mentioned this pull request

2016-05-17, Version 6.2.0 (Stable) #6810

Merged

evanlucas pushed a commit that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

f264749

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

evanlucas pushed a commit that referenced this pull request


          doc: fix deprecation warnings in addon examples

8f52649

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels

Contributor

MylesBorins commented May 18, 2016

I've marked this and #6396 as do not land for lts

No need for the fix if the regression isn't introduced. More than happy to review a backport of a working changeset

addaleax pushed a commit to addaleax/node that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

5b34603

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit to addaleax/node that referenced this pull request


          doc: fix deprecation warnings in addon examples

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax pushed a commit to addaleax/node that referenced this pull request


          build,test: fix build-addons dependency chain

6faecba

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax added a commit to addaleax/node that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

4e8e59b

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: nodejs#6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

5d7f7e7

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          doc: fix deprecation warnings in addon examples

ee5e3d0

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          build,test: fix build-addons dependency chain

1dee4b3

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

eb53ff3

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

fd5ec9b

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          doc: fix deprecation warnings in addon examples

4d3b450

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          build,test: fix build-addons dependency chain

4c85272

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

a79aed1

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins mentioned this pull request

v4.5.0 proposal #7688

Merged

MylesBorins pushed a commit that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          doc: fix deprecation warnings in addon examples

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          build,test: fix build-addons dependency chain

d34fa13

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

7304b0f

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: build addons with V8_DEPRECATION_WARNINGS=1

686d7b3

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          doc: fix deprecation warnings in addon examples

b869cdb

Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          build,test: fix build-addons dependency chain

ea20796

* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins pushed a commit that referenced this pull request


          tools: fix tools/doc/addon-verify.js regression

ed193ad

Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels