tools: remove minifying logic #6636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't minify so I'd simply remove that code. You can probably reduce the line count by quite a bit if you remove all minification-related code. |
|
@bnoordhuis The minifier actually has a bug, I was thinking about fixing it. Are we never going to use minifier? |
|
Okay, removed the entire minifying logic now. |
|
LGTM EDIT: You'll need to update the commit log, though. |
thefourtheye
changed the title
As the minifier logic is not used at all, this patch removes the code necessary for it.
thefourtheye
force-pushed
the
fix-jsmin-import
branch
from
cf69dfb
to
707b8c6
Compare
|
@bnoordhuis Thanks :-) Updated the commit message and log. |
|
LGTM |
|
Commit log LGTM. |
|
Landed in 0e2b250 |
thefourtheye
added a commit
that referenced
this pull request
May 12, 2016
As the minifier logic is not used at all, this patch removes the code necessary for it. PR-URL: #6636 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
As the minifier logic is not used at all, this patch removes the code necessary for it. PR-URL: #6636 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@thefourtheye lts? |
|
@thealphanerd Ya, we can LTS this. |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
As the minifier logic is not used at all, this patch removes the code necessary for it. PR-URL: #6636 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
As the minifier logic is not used at all, this patch removes the code necessary for it. PR-URL: #6636 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
As the minifier logic is not used at all, this patch removes the code necessary for it. PR-URL: #6636 Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
jsminmodule is imported to useJavaScriptMinifierclass, but theclass should be referenced with the module name. Otherwise, it will
throw a
NameErrorat runtime.As we don't use minifier at all, this patch removes the entire minifying logic.
cc @bnoordhuis
CI Run: https://ci.nodejs.org/job/node-test-pull-request/2538/