readline: remove deprecated methods #6423
Merged
+25
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
readline
|
LGTM. For anybody who wants to look it up, these were deprecated in #3862. |
|
LGTM. I have used |
|
LGTM |
|
|
LGTM is CI passes. |
|
No comments after review. |
|
LGTM, if CI is green. |
|
CI is green. CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/229/ |
|
@nodejs/ctc ... any objections on this assuming CITGM is good? |
|
@jasnell what is your take on the CITGM results? |
|
The body-parser and glob failures are known and unrelated. |
|
Failure from ws Looks like it could be flaky... I've just released a new version of CITGM which should make the results much cleaner... not 100% why the tap results are truncated there... might be something wrong with the reporter, will dig into that https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/231/ |
This commit removes the deprecated exports getStringWidth(), stripVTControlCharacters(), and isFullWidthCodePoint(). It also removes codePointAt() in its entirety, as it was deprecated and not being used by core. Refs: nodejs#3862 PR-URL: nodejs#6423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
This commit removes the deprecated exports getStringWidth(), stripVTControlCharacters(), and isFullWidthCodePoint(). It also removes codePointAt() in its entirety, as it was deprecated and not being used by core. Refs: nodejs#3862 PR-URL: nodejs#6423 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
readline
Description of change
This commit removes the deprecated exports
getStringWidth(),stripVTControlCharacters(), andisFullWidthCodePoint(). It also removescodePointAt()in its entirety, as it was deprecated andnot being used by core.