Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix EventEmitter#eventNames() example #6417

Closed
wants to merge 1 commit into from
Closed

doc: fix EventEmitter#eventNames() example #6417

wants to merge 1 commit into from

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Apr 27, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Replace myErr with myEE in one place (that was obviously a mistype).
Fix the expected output to have the actual formatting.

This was overlooked in #5617 (I also didn't notice that).

/cc @jasnell

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Apr 27, 2016
@ChALkeR ChALkeR mentioned this pull request Apr 27, 2016
Closed
@bnoordhuis
Copy link
Member

LGTM but you need to s/Fix EventEmmiter/fix EventEmitter/ in the commit log.

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 27, 2016

@bnoordhuis Done.

@cjihrig
Copy link
Contributor

cjihrig commented Apr 27, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Apr 27, 2016

LGTM
On Apr 27, 2016 3:01 AM, "Сковорода Никита Андреевич" <
notifications@github.com> wrote:

Checklist

  • documentation is changed or added
  • the commit message follows commit guidelines

Affected core subsystem(s)

doc
Description of change

Replace myErr with myEE in one place (that was obviously a mistype).
Fix the expected output to have the actual formatting.

This was overlooked in #5617 #5617
(I also didn't notice that).

/cc @jasnell https://github.com/jasnell

You can view, comment on, or merge this pull request online at:

#6417
Commit Summary

  • doc: Fix EventEmmiter#eventNames() example

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6417

@mscdex mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label Apr 27, 2016
@mscdex mscdex changed the title doc: Fix EventEmmiter#eventNames() example doc: Fix EventEmitter#eventNames() example Apr 27, 2016
@mscdex
Copy link
Contributor

mscdex commented Apr 27, 2016

LGTM but commit message still shows 'EventEmmiter'

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 27, 2016

@mscdex Ah, I didn't notice that, thanks! Will fix that.

@ChALkeR ChALkeR changed the title doc: Fix EventEmitter#eventNames() example doc: fix EventEmitter#eventNames() example Apr 27, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 27, 2016

@bnoordhuis, @mscdex Fixed.

@ChALkeR
doc: fix EventEmitter#eventNames() example
10e3efb 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: nodejs#6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@bnoordhuis
Copy link
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 30, 2016
@ChALkeR @jasnell
doc: fix EventEmitter#eventNames() example
c1f2df9 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: #6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Apr 30, 2016

Landed in c1f2df9

@jasnell jasnell closed this Apr 30, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
@ChALkeR @Fishrock123
doc: fix EventEmitter#eventNames() example
4068d64 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: #6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced May 4, 2016
Closed
Merged
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
@ChALkeR @joelostrowski
doc: fix EventEmitter#eventNames() example
c96df8d 
Replace myErr with myEE in one place.
Fix the expected output to have the actual formatting.

PR-URL: nodejs#6417
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins
Copy link
Contributor

@ChALkeR lts?

@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 2, 2016

@thealphanerd Perhaps. This is mostly just a typo fix in the docs.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jun 2, 2016 •
edited
Loading

moved to don't land

@ChALkeR feel free to file a backport PR if you like, it is by no means crucial though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChALkeR @bnoordhuis @cjihrig @jasnell @mscdex @MylesBorins