fix a typo in Buffer example code #6361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@c0b Mind editing your commit to include the subsystem of Note: this may get landed with that amended by us, but please keep it in mind for the future! :) |
it shows `Buffer(.from[1, 2, 3]);` but that doesn't run; should be a typo https://nodejs.org/dist/latest-v5.x/docs/api/buffer.html#buffer_buffers_and_es6_iteration resolve comment in nodejs@c1534e7#commitcomment-17228215 the same doc in master 85ab4a5 is correct.
|
sure; was reading online and editing thru github web interface; now should be done |
|
Commit message lines are a tad too long, but other than that LGTM |
|
LGTM |
1 similar comment
|
LGTM |
claudiorodriguez
pushed a commit
that referenced
this pull request
Apr 26, 2016
fixes `Buffer(.from[1, 2, 3])` into `Buffer.from(...)` (v5.x only) https://nodejs.org/dist/latest-v5.x/docs/api/buffer.html Commented in: c1534e7#commitcomment-17228215 PR-URL: #6361 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 9992048 into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
it shows
Buffer(.from[1, 2, 3]);but that doesn't run; should be a typoresolve comment in c1534e7#commitcomment-17228215; verified the same doc in master 85ab4a5 is correct.