doc: add stefanmb to collaborators #6227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanmb
added
the
meta
|
LGTM!
Welcome! |
| @@ -199,6 +199,7 @@ information about the governance of the Node.js project, see | |||
| * [seishun](https://github.com/seishun) - **Nikolai Vavilov** <vvnicholas@gmail.com> | |||
| * [silverwind](https://github.com/silverwind) - **Roman Reiss** <me@silverwind.io> | |||
| * [srl295](https://github.com/srl295) - **Steven R Loomis** <srloomis@us.ibm.com> | |||
| * [stefanmb](https://github.com/stefanmb) - **Stefan Budeanu** <stefan@budeanu.com> | |||
There was a problem hiding this comment.
nit: wouldn't you be about Steven alphabetically?
edit: don't mind me, nothing to see here
|
LGTM |
|
@thealphanerd srl295 goes before stefanmb since r is before t? |
|
we have sorted by username in the past. LGTM |
|
face palm... I forgot it was by username not real name... just ignore me 😄 |
|
@thealphanerd No worries :) Thanks for looking it over! |
stefanmb
force-pushed
the
readme-stefanmb
branch
from
83ecb52
to
9f7ecb7
Compare
PR-URL: nodejs#6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
stefanmb
force-pushed
the
readme-stefanmb
branch
from
9f7ecb7
to
f5b601e
Compare
|
LGTM |
|
Landed as 8c48a26 |
Trott
pushed a commit
that referenced
this pull request
Apr 15, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
PR-URL: nodejs#6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 1, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
PR-URL: #6227 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Adding myself (stefanmb)