build: allow test-ci to run tests in parallel #6208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yay! lgtm |
|
LGTM if CI is green |
jbergstroem
force-pushed
the
feature/parallel-jobs-in-makefile
branch
from
af394c3
to
9b99658
Compare
|
CI looking good but the speed increase isn't really evident |
|
@rvagg: most vm's doesn't have |
|
LGTM |
1 similar comment
|
LGTM |
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: nodejs#6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jbergstroem
force-pushed
the
feature/parallel-jobs-in-makefile
branch
from
9b99658
to
f49a1d0
Compare
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: #6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: #6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Apr 21, 2016
Closed
Closed
|
@jbergstroem lts? |
|
@thealphanerd sure. |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 21, 2016
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: #6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: nodejs#6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set. PR-URL: #6208 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
@jbergstroem this is not landing cleanly on v4.x-staing will likely need to be backported manually |
|
ping @jbergstroem |
|
Since #5638 is not landing I reckon we can skip this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
build
Description of change
Run tests in parallel if the environment variable JOBS (which should contain a number of parallel jobs) is set.
I'd like to expand this to the actual build steps as well (and possibly even outside of the
ciscope), but it requires careful testing since it seems to break here and there for some jobs./cc=@nodejs/build, @Trott, @bnoordhuis.