test: fix flaky test-net-socket-timeout-unref #6003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw immediately on socket timeout rather than checking boolean in exit handler. Fixes: nodejs#5128
Trott
added
net
|
Stress test confirming flakiness of current version on master: https://ci.nodejs.org/job/node-stress-single-test/584/nodes=pi2-raspbian-wheezy/console Stress test showing this version is not flaky: https://ci.nodejs.org/job/node-stress-single-test/583/nodes=pi2-raspbian-wheezy/console |
|
@nodejs/testing |
|
LGTM |
| process.on('exit', function() { | ||
| assert.strictEqual(timedout, false, | ||
| 'Socket timeout should not hold loop open'); | ||
| sockets.push({socket: socket, timeout: T * 1000}); |
There was a problem hiding this comment.
should this timout be platform specific?
There was a problem hiding this comment.
This is a socket timeout and not a timer, so I'm inclined to not make it platform dependent if it doesn't need to be.
There was a problem hiding this comment.
ahhh... /me leaves and reads more about socket time outs
|
LGTM with above nit assuming CI is green |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 4, 2016
Throw immediately on socket timeout rather than checking boolean in exit handler. PR-URL: nodejs#6003 Fixes: nodejs#5128 Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
Landed in c60faf6 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
test, net
Description of change
Throw immediately on socket timeout rather than checking boolean in exit
handler.
Fixes: #5128