Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mitigate flaky test-https-agent #5939

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 28, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test

Description of change

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5938
Refs: #5184

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: nodejs#5938
Refs: nodejs#5184
@Trott Trott added https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM platform. labels Mar 28, 2016
@Trott
Copy link
Member Author

Trott commented Mar 28, 2016

Stress test that will hopefully show that the current test is flaky on master:
https://ci.nodejs.org/job/node-stress-single-test/573/nodes=pi2-raspbian-wheezy/console

Stress test that will hopefully show that this version of the test is not flaky:
https://ci.nodejs.org/job/node-stress-single-test/574/nodes=pi2-raspbian-wheezy/console

@Trott
Copy link
Member Author

Trott commented Mar 28, 2016

Looks like the stress tests showed what they were supposed to show. Let's move on to general CI:

https://ci.nodejs.org/job/node-test-commit/2718/

@Trott
Copy link
Member Author

Trott commented Mar 29, 2016

CI is green. Review away!

@cjihrig
Copy link
Contributor

cjihrig commented Mar 29, 2016

Review away!

Ha. Not much to say here. CI is green, so LGTM.

@Fishrock123
Copy link
Contributor

lgtm

Trott added a commit to Trott/io.js that referenced this pull request Mar 30, 2016
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: nodejs#5939
Fixes: nodejs#5938
Refs: nodejs#5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 30, 2016

Landed in ea47cc4

@Trott Trott closed this Mar 30, 2016
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
@Trott Trott deleted the fix-https-agent branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Issues and PRs related to the ARM platform. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants