Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update TLS test for OpenSSL 3.2 #54612

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

richardlau
Copy link
Member

Update parallel/test-tls-set-sigalgs to account for error code changes in OpenSSL 3.2 and later.

Refs: #53382 (comment)
Refs: #53384

cc @nodejs/crypto


Addresses this failure with OpenSSL 3.2:

14:45:03 not ok 2996 parallel/test-tls-set-sigalgs
14:45:03   ---
14:45:03   duration_ms: 366.47000
14:45:03   severity: fail
14:45:03   exitcode: 1
14:45:03   stack: |-
14:45:03     (node:2717679) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
14:45:03     (Use `node --trace-deprecation ...` to show where the warning was created)
14:45:03     node:assert:126
14:45:03       throw new AssertionError(obj);
14:45:03       ^
14:45:03     
14:45:03     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
14:45:03     + actual - expected
14:45:03     
14:45:03     + 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE'
14:45:03     - 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE'
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/parallel/test-tls-set-sigalgs.js:51:16
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:488:15
14:45:03         at /home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/common/index.js:488:15
14:45:03         at maybeCallback (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/fixtures/tls-connect.js:97:7)
14:45:03         at TLSSocket.<anonymous> (/home/iojs/build/workspace/richardlau-node-test-commit-linux-containered/test/fixtures/tls-connect.js:73:13)
14:45:03         at TLSSocket.emit (node:events:520:28)
14:45:03         at emitErrorNT (node:internal/streams/destroy:170:8)
14:45:03         at emitErrorCloseNT (node:internal/streams/destroy:129:3)
14:45:03         at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
14:45:03       generatedMessage: true,
14:45:03       code: 'ERR_ASSERTION',
14:45:03       actual: 'ERR_SSL_SSL/TLS_ALERT_HANDSHAKE_FAILURE',
14:45:03       expected: 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
14:45:03       operator: 'strictEqual'
14:45:03     }
14:45:03     
14:45:03     Node.js v23.0.0-pre
14:45:03   ...

https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/32/nodes=ubuntu2204_sharedlibs_openssl32_x64/console

Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.
@richardlau richardlau added test Issues and PRs related to the tests. openssl Issues and PRs related to the OpenSSL dependency. labels Aug 28, 2024
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 28, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (4f14eb1) to head (932a99a).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54612      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.01%     
==========================================
  Files         649      649              
  Lines      182562   182562              
  Branches    35023    35030       +7     
==========================================
- Hits       159451   159446       -5     
+ Misses      16396    16390       -6     
- Partials     6715     6726      +11     

see 31 files with indirect coverage changes

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2024
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2bfc9e4 into nodejs:main Aug 30, 2024
68 checks passed
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 30, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
{
  "message": "Server Error"
}
https://github.com/nodejs/node/actions/runs/10635406195

@richardlau
Copy link
Member Author

Landed in 2bfc9e4.

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.

PR-URL: #54612
Refs: #53384
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.

PR-URL: #54612
Refs: #53384
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.

PR-URL: #54612
Refs: #53384
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.

PR-URL: nodejs#54612
Refs: nodejs#53384
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Sep 1, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes
in OpenSSL 3.2 and later.

PR-URL: #54612
Refs: #53384
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants