-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update TLS test for OpenSSL 3.2 #54612
Merged
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `parallel/test-tls-set-sigalgs` to account for error code changes in OpenSSL 3.2 and later.
richardlau
added
test
Issues and PRs related to the tests.
openssl
Issues and PRs related to the OpenSSL dependency.
labels
Aug 28, 2024
panva
approved these changes
Aug 28, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 28, 2024
lpinca
approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54612 +/- ##
==========================================
- Coverage 87.34% 87.33% -0.01%
==========================================
Files 649 649
Lines 182562 182562
Branches 35023 35030 +7
==========================================
- Hits 159451 159446 -5
+ Misses 16396 16390 -6
- Partials 6715 6726 +11 |
richardlau
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Aug 28, 2024
anonrig
approved these changes
Aug 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 29, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 30, 2024
nodejs-github-bot
added
the
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
label
Aug 30, 2024
Commit Queue failed{ "message": "Server Error" }https://github.com/nodejs/node/actions/runs/10635406195 |
Landed in 2bfc9e4. |
Merged
sendoru
pushed a commit
to sendoru/node
that referenced
this pull request
Sep 1, 2024
Update `parallel/test-tls-set-sigalgs` to account for error code changes in OpenSSL 3.2 and later. PR-URL: nodejs#54612 Refs: nodejs#53384 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
needs-ci
PRs that need a full CI run.
openssl
Issues and PRs related to the OpenSSL dependency.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
parallel/test-tls-set-sigalgs
to account for error code changes in OpenSSL 3.2 and later.Refs: #53382 (comment)
Refs: #53384
cc @nodejs/crypto
Addresses this failure with OpenSSL 3.2:
https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/32/nodes=ubuntu2204_sharedlibs_openssl32_x64/console