doc: explicitly mention node:fs module restriction #54269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
RafaelGSS
force-pushed
the
add-node-fs-mention
branch
from
6578bd1
to
61dcd86
Compare
RafaelGSS
added
the
commit-queue-squash
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
RafaelGSS
force-pushed
the
add-node-fs-mention
branch
from
743cdff
to
d882db1
Compare
tniessen
approved these changes
Aug 8, 2024
lpinca
approved these changes
Aug 10, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b49019e |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54269 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54269 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we have uncountable issues where we explicitly mention it, I somehow missed documenting it in permissions.md. I believe this would make things more clear.
cc: @tniessen