lib: fix typos in comments within internal/streams #54093
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed typos in comments within the internal/streams directory.
|
Review requested:
|
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Jul 29, 2024
fixed typos in comments within the internal/streams directory.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54093 +/- ##
==========================================
- Coverage 87.07% 87.05% -0.02%
==========================================
Files 643 643
Lines 181583 181583
Branches 34886 34876 -10
==========================================
- Hits 158114 158083 -31
- Misses 16751 16771 +20
- Partials 6718 6729 +11
|
|
@mcollina |
aduh95
added
author ready
jakecastelli
approved these changes
Jul 29, 2024
daeyeon
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54093 ✔ Done loading data for nodejs/node/pull/54093 ----------------------------------- PR info ------------------------------------ Title lib: fix typos in comments within internal/streams (#54093) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MCprotein:fix/typo -> nodejs:main Labels stream, author ready Commits 2 - lib: fix typos in comments within internal/streams - lib: fix typos in comments within internal/streams Committers 1 - MCprotein <chss3339@gmail.com> PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jul 2024 05:31:10 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54093#pullrequestreview-2203971053 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54093#pullrequestreview-2204037355 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54093#pullrequestreview-2205074194 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10174706907 |
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
trivikr
approved these changes
Aug 4, 2024
|
I will just re-request ci as there were some issues with windows build - nodejs/build#3848 |
github-actions
bot
removed
the
request-ci
jakecastelli
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54093 ✔ Done loading data for nodejs/node/pull/54093 ----------------------------------- PR info ------------------------------------ Title lib: fix typos in comments within internal/streams (#54093) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MCprotein:fix/typo -> nodejs:main Labels stream, author ready, needs-ci Commits 2 - lib: fix typos in comments within internal/streams - lib: fix typos in comments within internal/streams Committers 1 - MCprotein <chss3339@gmail.com> PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jul 2024 05:31:10 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54093#pullrequestreview-2203971053 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54093#pullrequestreview-2204037355 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54093#pullrequestreview-2205074194 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/54093#pullrequestreview-2217298130 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-04T12:24:09Z: https://ci.nodejs.org/job/node-test-pull-request/60865/ - Querying data for job/node-test-pull-request/60865/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 54093 From https://github.com/nodejs/node * branch refs/pull/54093/merge -> FETCH_HEAD ✔ Fetched commits as c6cf313bca11..1d5286845a69 -------------------------------------------------------------------------------- [main 3256e5c140] lib: fix typos in comments within internal/streams Author: MCprotein <chss3339@gmail.com> Date: Mon Jul 29 13:42:48 2024 +0900 4 files changed, 4 insertions(+), 4 deletions(-) [main 048b07ea25] lib: fix typos in comments within internal/streams Author: MCprotein <chss3339@gmail.com> Date: Mon Jul 29 15:03:36 2024 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/10240488109 |
daeyeon
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e6ee6e2 |
|
@jakecastelli @daeyeon thank you! |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
fixed typos in comments within the internal/streams directory. PR-URL: #54093 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed typos in comments within the internal/streams directory.