Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: disallow CJS <-> ESM edges in a cycle from require(esm) #52264

Merged
merged 2 commits into from
Apr 8, 2024
Merged

module: disallow CJS <-> ESM edges in a cycle from require(esm) #52264

merged 2 commits into from
Apr 8, 2024

Commits on Apr 5, 2024

  1. module: disallow CJS <-> ESM edges in a cycle from require(esm) 

    This patch disallows CJS <-> ESM edges when they come from
require(esm) requested in ESM evalaution.

Drive-by: don't reuse the cache for imported CJS modules to stash
source code of required ESM because the former is also used for
cycle detection.
    @joyeecheung
    joyeecheung committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    dc62194 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. fixup! module: disallow CJS <-> ESM edges in a cycle from require(esm)

    @joyeecheung
    joyeecheung committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    971affd View commit details
    Browse the repository at this point in the history