Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v20.x backport] test_runner: format coverage report for tap reporter #52260

Closed
wants to merge 3 commits into from
Closed

[v20.x backport] test_runner: format coverage report for tap reporter #52260

wants to merge 3 commits into from

Conversation

atlowChemi
Copy link
Member

@atlowChemi atlowChemi commented Mar 29, 2024 •
edited
Loading

This PR is a backport of #51119

PR-URL: #51119
Reviewed-By: Raz Luvaton rluvaton@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Debadree Chatterjee debadree333@gmail.com

H4ad and others added 3 commits March 28, 2024 16:35
@H4ad @richardlau
perf_hooks: reduce overhead of createHistogram
1daccf5 
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@H4ad @richardlau
test: avoid v8 deadcode on performance function
5ff73f3 
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@pulkit-30 @atlowChemi
test_runner: format coverage report for tap reporter
d2ac2e4 
PR-URL: nodejs#51119
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Mar 29, 2024
@atlowChemi atlowChemi mentioned this pull request Mar 29, 2024
Merged
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57996/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57997/

marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@pulkit-30 @marco-ippolito
test_runner: format coverage report for tap reporter
4fd1691 
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@pulkit-30 @marco-ippolito
test_runner: format coverage report for tap reporter
b23b38a 
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@pulkit-30 @marco-ippolito
test_runner: format coverage report for tap reporter
d5ac979 
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@marco-ippolito
Copy link
Member

Landed in d5ac979

@marco-ippolito marco-ippolito added the backported-to-v20.x PRs backported to the v20.x-staging branch. label Apr 29, 2024
@richardlau
Copy link
Member

Landed in d5ac979

@marco-ippolito There were three commits in this PR.

@marco-ippolito
Copy link
Member

marco-ippolito commented Apr 29, 2024 •
edited
Loading

Landed in d5ac979

@marco-ippolito There were three commits in this PR.

they we already pulled in v20 by another backport so I didnt duplicate them
v20.x...v20.x-staging
Is it alright?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Assignees
No one assigned
Labels
backported-to-v20.x PRs backported to the v20.x-staging branch. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@atlowChemi @nodejs-github-bot @marco-ippolito @richardlau @lpinca @MoLow @mertcanaltin @H4ad @pulkit-30