-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add release key for marco-ippolito #52257
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,10 +90,11 @@ responsible for that release. In order to be able to verify downloaded binaries, | |
the public should be able to check that the `SHASUMS256.txt` file has been | ||
signed by someone who has been authorized to create a release. | ||
|
||
The GPG keys should be fetchable from a known third-party keyserver. The SKS | ||
Keyservers at <https://sks-keyservers.net> are recommended. Use the | ||
[submission](https://pgp.mit.edu/) form to submit a new GPG key. You'll need to | ||
do an ASCII-armored export of your key first: | ||
The public keys should be fetchable from a known third-party keyserver. | ||
The OpenPGP keyserver at <https://keys.openpgp.org/> is recommended. | ||
Use the [submission](https://keys.openpgp.org/upload) form to submit | ||
a new public key, and make sure to verify the associated email. | ||
You'll need to do an ASCII-armored export of your key first: | ||
|
||
```bash | ||
gpg --armor --export email@server.com > ~/nodekey.asc | ||
|
@@ -102,7 +103,7 @@ gpg --armor --export email@server.com > ~/nodekey.asc | |
Keys should be fetchable via: | ||
|
||
```bash | ||
gpg --keyserver pool.sks-keyservers.net --recv-keys <FINGERPRINT> | ||
gpg --keyserver hkps://keys.openpgp.org --recv-keys <FINGERPRINT> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this change made here? I couldn't find any public reasoning for this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
``` | ||
|
||
The key you use may be a child/subkey of an existing key. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, I think we should make this change on a different pull-request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's split in two commits, the current onboarding documentation is wrong, and since I was following it, I took the chance to update it