Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove redundant backquote which breaks sentence #51904

Merged
merged 1 commit into from
Feb 28, 2024
Merged

doc: remove redundant backquote which breaks sentence #51904

merged 1 commit into from
Feb 28, 2024

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Feb 28, 2024

image

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Feb 28, 2024
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@JounQin JounQin changed the title docs: remove redundant backquote which breaks sentence doc: remove redundant backquote which breaks sentence Feb 28, 2024
@JounQin
Copy link
Contributor Author

JounQin commented Feb 28, 2024

@MoLow Hi, sorry, my first commit message docs: does not match the CI linter, I've adapt the correct format with a force push.

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit 2f01f02 into nodejs:main Feb 28, 2024
15 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2f01f02

@JounQin JounQin deleted the patch-1 branch February 28, 2024 10:55
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@JounQin @marco-ippolito
doc: remove redundant backquote which breaks sentence
2134280 
PR-URL: #51904
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@JounQin @marco-ippolito
doc: remove redundant backquote which breaks sentence
3fdaeba 
PR-URL: #51904
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@JounQin @richardlau
doc: remove redundant backquote which breaks sentence
fd297ea 
PR-URL: #51904
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@JounQin @richardlau
doc: remove redundant backquote which breaks sentence
473af94 
PR-URL: #51904
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@JounQin @rdw-msft
doc: remove redundant backquote which breaks sentence
b4a9d05 
PR-URL: nodejs#51904
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@MoLow MoLow MoLow approved these changes

@theanarkh theanarkh theanarkh approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JounQin @nodejs-github-bot @JakobJingleheimer @Ayase-252 @MoLow @theanarkh