Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ngtcp2 to 1.3.0 #51796

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of ngtcp2 to 1.3.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 18, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Feb 18, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0350609 into main Feb 26, 2024
61 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ngtcp2 branch February 26, 2024 13:03
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 0350609

marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
PR-URL: nodejs#51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito marco-ippolito added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 1, 2024
richardlau pushed a commit that referenced this pull request May 10, 2024
PR-URL: #51796
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@richardlau richardlau mentioned this pull request May 16, 2024
@marco-ippolito
Copy link
Member

marco-ippolito commented May 23, 2024

it doesnt land cleanly on v20.x, I tried to fix conflict but it fails during build, so I'll request backport

@marco-ippolito marco-ippolito added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label May 23, 2024
@targos
Copy link
Member

targos commented May 23, 2024

I wonder what explains the presence of a conflict here.

@marco-ippolito
Copy link
Member

marco-ippolito commented May 23, 2024

I wonder what explains the presence of a conflict here.

The only reason could be security release? the version on v20.x-staging is 1.1.0, I haven't investigated though

@targos
Copy link
Member

targos commented May 23, 2024

The missing PRs before this one are:

They're both labeled dont-land-on-v20.x

@marco-ippolito marco-ippolito added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants