Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix warning in cares under GN build #51687

Closed
wants to merge 1 commit into from
Closed

build: fix warning in cares under GN build #51687

wants to merge 1 commit into from

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 7, 2024

This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 7, 2024
@zcbenz
Copy link
Contributor Author

zcbenz commented Feb 13, 2024

Can this be merged? It is currently breaking GN build.

@merceyz merceyz mentioned this pull request Feb 14, 2024
Closed
@victorgomes
Copy link

+1 It is breaking V8 Node CI. Duplicate: #51756

@targos
Copy link
Member

targos commented Feb 14, 2024

This should be merged quickly after the security release.

juanarbol
juanarbol approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanarbol juanarbol added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @juanarbol. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57077/

@targos targos removed the fast-track PRs that do not need to wait for 48 hours to land. label Feb 19, 2024
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57230/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57232/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57233/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57238/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57241/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57245/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57250/

@zcbenz
build: fix warning in cares under GN build
c01e971 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709
@zcbenz zcbenz added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57318/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57327/

@zcbenz zcbenz added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 23, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51687
✔  Done loading data for nodejs/node/pull/51687
----------------------------------- PR info ------------------------------------
Title      build: fix warning in cares under GN build (#51687)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zcbenz:cares-warning -> nodejs:main
Labels     cares, needs-ci, dependencies, commit-queue-squash
Commits    1
 - build: fix warning in cares under GN build
Committers 1
 - Cheng Zhao 
PR-URL: https://github.com/nodejs/node/pull/51687
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Juan José Arboleda 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51687
Reviewed-By: Luigi Pinca 
Reviewed-By: Marco Ippolito 
Reviewed-By: Juan José Arboleda 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - build: fix warning in cares under GN build
   ℹ  This PR was created on Wed, 07 Feb 2024 05:21:35 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867015435
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51687#pullrequestreview-1867295688
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/51687#pullrequestreview-1880447000
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-02-23T05:51:27Z: https://ci.nodejs.org/job/node-test-pull-request/57327/
- Querying data for job/node-test-pull-request/57327/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/8015803850

zcbenz added a commit that referenced this pull request Feb 23, 2024
@zcbenz
build: fix warning in cares under GN build
f22802c 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@zcbenz
Copy link
Contributor Author

zcbenz commented Feb 23, 2024

Landed in f22802c

@zcbenz zcbenz closed this Feb 23, 2024
@zcbenz zcbenz deleted the cares-warning branch February 23, 2024 07:11
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@zcbenz @marco-ippolito
build: fix warning in cares under GN build
99fed49 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@zcbenz @marco-ippolito
build: fix warning in cares under GN build
d28c3fb 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@zcbenz @marco-ippolito
build: fix warning in cares under GN build
9be6b7c 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@zcbenz @richardlau
build: fix warning in cares under GN build
114d2e6 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@zcbenz @richardlau
build: fix warning in cares under GN build
93fcf52 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: #51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@zcbenz @rdw-msft
build: fix warning in cares under GN build
d2ab8d4 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709

PR-URL: nodejs#51687
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zcbenz @nodejs-github-bot @victorgomes @targos @lpinca @juanarbol @marco-ippolito