Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-http2-large-file as flaky #51549

Merged
merged 1 commit into from
Jan 25, 2024
Merged

test: mark test-http2-large-file as flaky #51549

merged 1 commit into from
Jan 25, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jan 23, 2024

Refs: #47409

@targos targos mentioned this pull request Jan 23, 2024
Open
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 23, 2024
@targos targos added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. labels Jan 23, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56898/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56900/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56905/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2024
@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6b6bcee into nodejs:main Jan 25, 2024
70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6b6bcee

@targos targos deleted the flaky-http2-large-file branch January 25, 2024 13:45
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
@targos @marco-ippolito
test: mark test-http2-large-file as flaky
171f7dc 
Refs: nodejs#47409
PR-URL: nodejs#51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@targos @rdw-msft
test: mark test-http2-large-file as flaky
a218420 
Refs: nodejs#47409
PR-URL: nodejs#51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos added a commit that referenced this pull request Feb 15, 2024
@targos
test: mark test-http2-large-file as flaky
fc0c130 
Refs: #47409
PR-URL: #51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@targos @marco-ippolito
test: mark test-http2-large-file as flaky
a94ca67 
Refs: nodejs#47409
PR-URL: nodejs#51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@targos @richardlau
test: mark test-http2-large-file as flaky
d6bbd9f 
Refs: #47409
PR-URL: #51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@targos @richardlau
test: mark test-http2-large-file as flaky
f6fcd20 
Refs: #47409
PR-URL: #51549
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @lpinca @anonrig @richardlau @StefanStojanovic