Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #51533

Merged
merged 1 commit into from
Jan 22, 2024
Merged

test,crypto: update WebCryptoAPI WPT #51533

merged 1 commit into from
Jan 22, 2024

Conversation

panva
Copy link
Member

@panva panva commented Jan 20, 2024

Just git node wpt WebCryptoAPI.

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Jan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56851/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56852/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56854/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56856/

aduh95
aduh95 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2024
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6c34243 into nodejs:main Jan 22, 2024
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6c34243

@panva panva deleted the bump-webcrypto-wpt branch January 25, 2024 08:20
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
@panva @marco-ippolito
test,crypto: update WebCryptoAPI WPT
1bdfce1 
PR-URL: nodejs#51533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@panva @targos
test,crypto: update WebCryptoAPI WPT
9dfb36f 
PR-URL: #51533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@panva @marco-ippolito
test,crypto: update WebCryptoAPI WPT
3882446 
PR-URL: nodejs#51533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@panva @richardlau
test,crypto: update WebCryptoAPI WPT
2d899fd 
PR-URL: #51533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@panva @richardlau
test,crypto: update WebCryptoAPI WPT
1c47da1 
PR-URL: #51533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @benjamingr @lpinca @aduh95