Allow checking the test result from afterEach #51485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
tims-bsquare
force-pushed
the
test-after-each-access-result
branch
from
9a559a9
to
f748568
Compare
|
Amended the commit message to match guidelines |
MoLow
reviewed
Jan 16, 2024
benjamingr
approved these changes
Jan 17, 2024
MoLow
approved these changes
Jan 18, 2024
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
reviewed
Jan 18, 2024
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d755f1a |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 22, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
PR-URL: nodejs#51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51485 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets users check the result of the test in the afterEach hook. It's handy for example when doing Selenium tests where if a test fails you want to take a screenshot then do some cleanup.