Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update iterations of benchmark/async_hooks/async-local-sto… #51434

Conversation

lucshi
Copy link
Contributor

@lucshi lucshi commented Jan 11, 2024

…rage-

propagate-asyncresource.js

Fixes: #50571

Increase the iterations to let the test case trigger the real testing logic, not spending most cycles on loading the JS file itself.

<style> </style>
    after PR before PR benefit
async_hooks/async-local-storage-propagate-asyncresource.js storageCount=0: 12349870.34 1562324.239 790%
async_hooks/async-local-storage-propagate-asyncresource.js storageCount=1: 7670267.474 685786.8616 1118%
async_hooks/async-local-storage-propagate-asyncresource.js storageCount=10: 2800733.21 350653.7589 799%
async_hooks/async-local-storage-propagate-asyncresource.js storageCount=100: 159107.3396 95701.24369 166%

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 11, 2024
@lucshi lucshi force-pushed the async_hooks/async-local-storage-propagate-asyncresource.js branch from dccb88c to 0a247a8 Compare January 11, 2024 03:01
@lucshi lucshi closed this Feb 29, 2024
@lucshi lucshi deleted the async_hooks/async-local-storage-propagate-asyncresource.js branch February 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes
2 participants