-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update nghttp3 to 1.5.0 #51321
base: main
Are you sure you want to change the base?
Conversation
@jasnell do those dummy line additions makes sense to you? |
We probably need to add a line to the .gitignore like https://github.com/nodejs/node/blob/75ed4eeba518b2bfc999b0fe4ee56d09cc4cdc52/deps/ngtcp2/.gitignore#L8C1-L8C1 |
Not really |
58e309f
to
792842f
Compare
@marco-ippolito I think something might be wrong with the updater script as the current form of the PR does not make a lot of sense to me. Is that something you could take a look at? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as changes needed so that it does not land until we figure out if it makes sense or not.
to launch update locally, its required to have pkg-config, issue related: ngtcp2/nghttp3#147. Anyways, I downloaded the new release 1.1.0, run configure, deleted deps/ngtcp2/nghttp3/lib and replaced with the lib folder from the release. It matches with the changes created by the script. |
I can reproduce the same update locally. I think the lack of changes is due to #51291, which didn't update the version.h |
@marco-ippolito, @targos thanks for taking a look, removing my block since it sounds like it makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7301dfd
to
3701769
Compare
Build is failing with
|
sfparse is now a git submodule in upstream nghttp3: ngtcp2/nghttp3@e755bfb |
This is an automated update of nghttp3 to 1.5.0.