deps: update nghttp3 to 1.5.0

[nodejs-github-bot]

This is an automated update of nghttp3 to 1.5.0.

[mhdawson]

@jasnell do those dummy line additions makes sense to you?

[targos]

We probably need to add a line to the .gitignore like https://github.com/nodejs/node/blob/75ed4eeba518b2bfc999b0fe4ee56d09cc4cdc52/deps/ngtcp2/.gitignore#L8C1-L8C1

[jasnell]

do those dummy line additions makes sense to you?

Not really

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56882/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56910/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56921/

[mhdawson]

@marco-ippolito I think something might be wrong with the updater script as the current form of the PR does not make a lot of sense to me. Is that something you could take a look at?

[mhdawson]

Marking as changes needed so that it does not land until we figure out if it makes sense or not.

[marco-ippolito]

to launch update locally, its required to have pkg-config, issue related: ngtcp2/nghttp3#147.

Anyways, I downloaded the new release 1.1.0, run configure, deleted deps/ngtcp2/nghttp3/lib and replaced with the lib folder from the release. It matches with the changes created by the script.
@mhdawson it seems no changes has been done in the lib folder in previous releases so this makes sense.

[targos]

I can reproduce the same update locally. I think the lack of changes is due to #51291, which didn't update the version.h

[mhdawson]

@marco-ippolito, @targos thanks for taking a look, removing my block since it sounds like it makes sense.

[mhdawson]

LGTM

[aduh95]

Build is failing with

../deps/ngtcp2/nghttp3/lib/nghttp3_http.c:35:10: fatal error: sfparse/sfparse.h: No such file or directory
   35 | #include "sfparse/sfparse.h"
      |          ^~~~~~~~~~~~~~~~~~~

[richardlau]

sfparse is now a git submodule in upstream nghttp3: ngtcp2/nghttp3@e755bfb