Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path: performance and stability improvements on all platforms #5123

Closed
wants to merge 4 commits into from
Closed

path: performance and stability improvements on all platforms #5123

wants to merge 4 commits into from

Commits on Feb 6, 2016

  1. benchmark: allow empty parameters

    @mscdex
    mscdex committed Feb 6, 2016
    Configuration menu
    Copy the full SHA
    90da034 View commit details
    Browse the repository at this point in the history

  2. benchmark: split path benchmarks 

    This commit splits each path benchmark into separate posix and
Windows benchmark files. This allows benchmarking (platform-)specific
inputs against specific platforms (only).
    @mscdex
    mscdex committed Feb 6, 2016
    Configuration menu
    Copy the full SHA
    9b28ca2 View commit details
    Browse the repository at this point in the history

  3. test: improve path tests 

    This commit adds new tests, executes tests for other platforms
instead of limiting platform-specific tests to those platforms,
and fixes a few style/formatting inconsistencies.
    @mscdex
    mscdex committed Feb 6, 2016
    Configuration menu
    Copy the full SHA
    d8556dd View commit details
    Browse the repository at this point in the history

  4. path: performance improvements on all platforms 

    This commit significantly improves performance of all path functions.

Optimization strategies include:
* Replacing regexps with manual parsers
* Avoiding unnecessary array creation (including split() + join())
* Returning earlier where possible to avoid unnecessary work
* Minimize unnecessary string creation and concatenations
* Combining string iterations
    @mscdex
    mscdex committed Feb 6, 2016
    3 Configuration menu
    Copy the full SHA
    66be01c View commit details
    Browse the repository at this point in the history