Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: escape cwd in regexp #50980

Merged
merged 1 commit into from
Dec 5, 2023
Merged

test: escape cwd in regexp #50980

merged 1 commit into from
Dec 5, 2023

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Nov 30, 2023

Some signs in cwd could make this regexp fail

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 30, 2023
@kapouer kapouer changed the title [test] Escape cwd in regexp test: Escape cwd in regexp Nov 30, 2023
@kapouer kapouer changed the title test: Escape cwd in regexp test: escape cwd in regexp Nov 30, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56039/

MoLow
MoLow approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to revert @aduh95 's suggestion since it uses common js

@kapouer @aduh95
test: escape cwd in regexp
46a30e6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56086/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56089/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit fba2c93 into nodejs:main Dec 5, 2023
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fba2c93

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@kapouer @aduh95 @RafaelGSS
test: escape cwd in regexp
4ddd0da 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #50980
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@kapouer @aduh95 @richardlau
test: escape cwd in regexp
a4f1805 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #50980
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kapouer @nodejs-github-bot @benjamingr @lpinca @MoLow @aduh95 @atlowChemi