Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add triggers to update release links workflow #50974

Merged
merged 2 commits into from
Nov 30, 2023
Merged

tools: add triggers to update release links workflow #50974

merged 2 commits into from
Nov 30, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Nov 30, 2023

No description provided.

@MoLow MoLow requested a review from targos November 30, 2023 13:46
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 30, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 30, 2023
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos
Copy link
Member

targos commented Nov 30, 2023

Requesting fast-track. This can hopefully land before the release of v21.x that happens today.

@MoLow @targos
Update .github/workflows/update-release-links.yml
266bda9 
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@MoLow MoLow added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 30, 2023
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2023
@nodejs-github-bot nodejs-github-bot merged commit a70d9e5 into nodejs:main Nov 30, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a70d9e5

@MoLow MoLow deleted the add-released-trigger branch November 30, 2023 14:05
targos pushed a commit that referenced this pull request Dec 4, 2023
@MoLow @targos
tools: add triggers to update release links workflow
8e1a70a 
PR-URL: #50974
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Dec 4, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MoLow @richardlau
tools: add triggers to update release links workflow
450163c 
PR-URL: #50974
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MoLow @nodejs-github-bot @targos @aduh95