Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reserve 121 for Electron 29 #50957

Merged
merged 1 commit into from
Nov 29, 2023
Merged

doc: reserve 121 for Electron 29 #50957

merged 1 commit into from
Nov 29, 2023

Conversation

codebytere
Copy link
Member

This PR reserves NMV 121 for Electron 29.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 28, 2023
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 0d4a1b3 into nodejs:main Nov 29, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0d4a1b3

targos pushed a commit that referenced this pull request Dec 4, 2023
@codebytere @targos
doc: reserve 121 for Electron 29
759ebca 
PR-URL: #50957
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Dec 4, 2023
Merged
@VerteDinde VerteDinde mentioned this pull request Dec 6, 2023
Merged
5 tasks
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@codebytere @richardlau
doc: reserve 121 for Electron 29
ddc7964 
PR-URL: #50957
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@aymen94 aymen94 aymen94 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@codebytere @nodejs-github-bot @lpinca @anonrig @targos @richardlau @MoLow @aymen94 @aduh95