Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix current version check for minimatch, acorn, acorn-walk #50951

Merged
merged 2 commits into from
Nov 28, 2023
Merged

tools: fix current version check for minimatch, acorn, acorn-walk #50951

merged 2 commits into from
Nov 28, 2023

Conversation

marco-ippolito
Copy link
Member

related to:
#50912
It was comparing versions in a different format

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 28, 2023
@marco-ippolito marco-ippolito changed the title tools: fix current version check tools: fix current version check for minimatch, acorn, acorn-walk Nov 28, 2023
aduh95
aduh95 approved these changes Nov 28, 2023
View reviewed changes
tools/dep_updaters/update-minimatch.sh Outdated Show resolved Hide resolved
@marco-ippolito @aduh95
Update tools/dep_updaters/update-minimatch.sh
9a67eed 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
mhdawson
mhdawson approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@mhdawson mhdawson added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit ef5c8e4 into nodejs:main Nov 28, 2023
32 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ef5c8e4

targos pushed a commit that referenced this pull request Dec 4, 2023
@marco-ippolito @targos
tools: fix current version check
1e40c4a 
PR-URL: #50951
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Dec 4, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
tools: fix current version check
6fc6a62 
PR-URL: #50951
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marco-ippolito @nodejs-github-bot @lpinca @MoLow @mhdawson @aduh95