lib: expose default prepareStackTrace #50827

legendecas · 2023-11-20T17:57:30Z

repl: fix prepareStackTrace frames array order

The second parameter of Error.prepareStackTrace is an array of
reversed call site frames.

lib: expose default prepareStackTrace

Expose the default prepareStackTrace implementation as
Error.prepareStackTrace so that userland can chain up formatting of
stack traces with built-in source maps support.

Fixes: #50733

nodejs-github-bot · 2023-11-20T17:57:36Z

Review requested:

@nodejs/loaders
@nodejs/startup

GeoffreyBooth · 2023-11-20T18:29:33Z

Can people call this function as a replacement for Error.prepareStackTrace? If not then we should maybe name it defaultPrepareStackTrace.

doc/api/module.md

lib/internal/errors.js

Ethan-Arrowood

this looks good. can you make the new test file ESM? I believe we are trying to make all net-new tests ESM now

test/fixtures/source-map/output/source_map_prepare_stack_trace.js

doc/api/cli.md

lib/repl.js

The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames.

Expose the default prepareStackTrace implementation as `Error.prepareStackTrace` so that userland can chain up formatting of stack traces with built-in source maps support.

legendecas · 2023-12-10T15:38:35Z

@joyeecheung would you mind taking a look at this PR again? Thank you very much!

nodejs-github-bot · 2023-12-10T15:40:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56208/

legendecas · 2023-12-10T15:41:20Z

@GeoffreyBooth: Can people call this function as a replacement for Error.prepareStackTrace? If not then we should maybe name it defaultPrepareStackTrace.

Updated the PR to expose the default implementation as Error.prepareStackTrace instead. Would you mind taking a look again? Thank you

nodejs-github-bot · 2023-12-11T02:45:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56218/

lib/internal/errors.js

doc/api/cli.md

legendecas · 2023-12-20T16:50:36Z

@GeoffreyBooth would you mind taking a look again? Thank you!

nodejs-github-bot · 2023-12-20T16:50:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56413/

GeoffreyBooth

Looks great, thanks! 👍

nodejs-github-bot · 2023-12-21T14:22:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/56438/

nodejs-github-bot · 2023-12-21T16:56:37Z

Landed in fe918f5...147abb9

The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Expose the default prepareStackTrace implementation as `Error.prepareStackTrace` so that userland can chain up formatting of stack traces with built-in source maps support. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Expose the default prepareStackTrace implementation as `Error.prepareStackTrace` so that userland can chain up formatting of stack traces with built-in source maps support. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Expose the default prepareStackTrace implementation as `Error.prepareStackTrace` so that userland can chain up formatting of stack traces with built-in source maps support. PR-URL: #50827 Fixes: #50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 20, 2023

legendecas mentioned this pull request Nov 20, 2023

Allow using --enable-source-maps together with custom Error.prepareStackTrace #50733

Closed

joyeecheung reviewed Nov 20, 2023

View reviewed changes

doc/api/module.md Outdated Show resolved Hide resolved

doc/api/module.md Outdated Show resolved Hide resolved

doc/api/module.md Outdated Show resolved Hide resolved

lib/internal/errors.js Outdated Show resolved Hide resolved

legendecas force-pushed the source_maps/prepare_stack_trace branch 4 times, most recently from 2a5b908 to 5bbcf91 Compare November 21, 2023 18:37

Ethan-Arrowood approved these changes Nov 21, 2023

View reviewed changes

test/fixtures/source-map/output/source_map_prepare_stack_trace.js Outdated Show resolved Hide resolved

joyeecheung reviewed Nov 22, 2023

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

lib/repl.js Outdated Show resolved Hide resolved

legendecas and others added 2 commits November 27, 2023 23:46

repl: fix prepareStackTrace frames array order

99349b1

The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames.

lib: expose default prepareStackTrace

f281bc4

Expose the default prepareStackTrace implementation as `Error.prepareStackTrace` so that userland can chain up formatting of stack traces with built-in source maps support.

legendecas force-pushed the source_maps/prepare_stack_trace branch from 5bbcf91 to f281bc4 Compare November 27, 2023 15:47

jasnell approved these changes Dec 9, 2023

View reviewed changes

legendecas added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 10, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2023

joyeecheung approved these changes Dec 11, 2023

View reviewed changes

GeoffreyBooth reviewed Dec 11, 2023

View reviewed changes

lib/internal/errors.js Show resolved Hide resolved

lib/internal/errors.js Outdated Show resolved Hide resolved

doc/api/cli.md Show resolved Hide resolved

fixup! lib: expose default prepareStackTrace

44d5c42

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2023

GeoffreyBooth approved these changes Dec 20, 2023

View reviewed changes

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2023

nodejs-github-bot closed this Dec 21, 2023

legendecas deleted the source_maps/prepare_stack_trace branch December 21, 2023 16:59

RafaelGSS mentioned this pull request Jan 2, 2024

v21.6.0 proposal #51342

Merged

This was referenced Jan 15, 2024

support node --enable-source-maps usage with our custom Error.prepareStackTrace usage elastic/apm-agent-nodejs#3833

Open

chore(deps-dev): bump undici from 6.2.1 to 6.3.0 elastic/apm-agent-nodejs#3827

Merged

legendecas mentioned this pull request Mar 19, 2024

Getting stack traces with and without source maps #51853

Open

richardlau mentioned this pull request Mar 25, 2024

v20.12.0 proposal #52212

Merged

cenfun mentioned this pull request Apr 2, 2024

VS Code breakpoint with tsx and Nodejs 20.12.0 does not work privatenumber/tsx#506

Closed

6 tasks

privatenumber mentioned this pull request Apr 4, 2024

fix: source maps in Node v21.6.0+ & v20.12.0+ privatenumber/tsx#518

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: expose default prepareStackTrace #50827

lib: expose default prepareStackTrace #50827

legendecas commented Nov 20, 2023 •

edited

Loading

nodejs-github-bot commented Nov 20, 2023

GeoffreyBooth commented Nov 20, 2023

Ethan-Arrowood left a comment

legendecas commented Dec 10, 2023

nodejs-github-bot commented Dec 10, 2023

legendecas commented Dec 10, 2023 •

edited

Loading

nodejs-github-bot commented Dec 11, 2023

legendecas commented Dec 20, 2023

nodejs-github-bot commented Dec 20, 2023

GeoffreyBooth left a comment

nodejs-github-bot commented Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023

lib: expose default prepareStackTrace #50827

lib: expose default prepareStackTrace #50827

Conversation

legendecas commented Nov 20, 2023 • edited Loading

repl: fix prepareStackTrace frames array order

lib: expose default prepareStackTrace

nodejs-github-bot commented Nov 20, 2023

GeoffreyBooth commented Nov 20, 2023

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

legendecas commented Dec 10, 2023

nodejs-github-bot commented Dec 10, 2023

legendecas commented Dec 10, 2023 • edited Loading

nodejs-github-bot commented Dec 11, 2023

legendecas commented Dec 20, 2023

nodejs-github-bot commented Dec 20, 2023

GeoffreyBooth left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Dec 21, 2023

nodejs-github-bot commented Dec 21, 2023

legendecas commented Nov 20, 2023 •

edited

Loading

legendecas commented Dec 10, 2023 •

edited

Loading