Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update nghttp3 to 1.1.0 #50677

Closed
wants to merge 1 commit into from
Closed

deps: update nghttp3 to 1.1.0 #50677

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Nov 12, 2023 •
edited
Loading

This is an automated update of nghttp3 to 1.1.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Nov 12, 2023
jasnell
jasnell requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. This is going to need manual intervention to work correctly but if I close this the autopatcher is going to keep trying apparently. I will update this manually soon.

@nodejs-github-bot nodejs-github-bot changed the title deps: update nghttp3 to 1.0.0 deps: update nghttp3 to 1.1.0 Dec 3, 2023
@targos targos force-pushed the actions/tools-update-nghttp3 branch from 7ccd368 to 6c14ba6 Compare December 23, 2023 11:04
@targos
Copy link
Member

targos commented Dec 23, 2023

Just rebased, fixed the conflict and updated the gyp file.

@targos targos force-pushed the actions/tools-update-nghttp3 branch from 6c14ba6 to 3705453 Compare December 23, 2023 13:46
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56478/

@lpinca
Copy link
Member

lpinca commented Dec 27, 2023 •
edited
Loading

Closing in favor of #51291.

@lpinca lpinca closed this Dec 27, 2023
@lpinca lpinca deleted the actions/tools-update-nghttp3 branch December 27, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell requested changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @targos @lpinca @jasnell