-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: set test-http-regr-gh-2928
as flaky
#50228
Conversation
bbbf92b
to
9c86662
Compare
9c86662
to
fbefa4b
Compare
It is flaky only on Windows 2016, I wonder if there is something wrong on the test machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is flaky only on Windows 2016, I wonder if there is something wrong on the test machine.
I had my suspicions about the x86 build that was tested there, but couldn't reproduce locally. Regarding the machines, those are planned for removal soon, so we can check after that happens to see if it was only machines or something else. Until that happens, I'm OK with marking the test as flaky.
@richardlau is it possible to add the the Windows 2016 to the diff --git a/test/sequential/test-http-regr-gh-2928.js b/test/sequential/test-http-regr-gh-2928.js
index 25476e0453..f6a9e16032 100644
--- a/test/sequential/test-http-regr-gh-2928.js
+++ b/test/sequential/test-http-regr-gh-2928.js
@@ -8,6 +8,8 @@ const httpCommon = require('_http_common');
const { HTTPParser } = require('_http_common');
const net = require('net');
+httpCommon.parsers.max = 50;
+
const COUNT = httpCommon.parsers.max + 1;
const parsers = new Array(COUNT);
We might want to apply it regardless of whether it solves the issue or not. There is no reason to use 1000 parsers in the test. |
The job already has In the node-test-commit-windows-fanned job Node.js is compiled for Windows on one machine and then the binary is copied over to other machines (e.g. the win2016 machines) for testing. |
I understand, thank you. |
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Can we try with #50240 before landing this? |
The maximum number of parses in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs#50228 (comment)
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs#50228 (comment)
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs#50228 (comment) PR-URL: nodejs#50240 Fixes: nodejs#49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Backport-PR-URL: #52384 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: nodejs/node#50228 (comment) PR-URL: nodejs/node#50240 Fixes: nodejs/node#49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Ref: #49564