Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix inconsistent styling #4996

Closed
wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 31, 2016

No description provided.

@mscdex mscdex added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Jan 31, 2016
is not in the root certificates list. (You could provide an issuer via `ca`
option.)
NOTE: `issuer` could be `null`, if the certificate is self-signed or if the
issuer is not in the root certificates list. (You could provide an issuer via
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, while you're in there: Remove personal pronoun.

Before:

You could provide an issuer via ca option.

After, something like:

An issuer may be provided via the ca option.

@Trott
Copy link
Member

Trott commented Jan 31, 2016

LGTM with a take-it-or-leave-it nit.

@targos
Copy link
Member

targos commented Jan 31, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

LGTM with nit addressed

@mscdex
Copy link
Contributor Author

mscdex commented Feb 4, 2016

Wording changed as suggested.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 4, 2016

LGTM

2 similar comments
@DavidTPate
Copy link

LGTM

@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
PR-URL: #4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

Landed in 01dd8ed

@jasnell jasnell closed this Feb 4, 2016
@mscdex mscdex deleted the doc-tls-fix-styling branch February 4, 2016 19:14
rvagg pushed a commit that referenced this pull request Feb 8, 2016
PR-URL: #4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

The changes in this are fairly minor, not landing cleanly, and bringing over other changes.

I'm changing to dont-land for now. Please feel free to manually backport or get the conversation going again

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
PR-URL: nodejs#4996
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants