Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for..of in test-net-isipv6.js #49823

Closed
wants to merge 4 commits into from
Closed

test: replace forEach with for..of in test-net-isipv6.js #49823

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86bdd2a
test: replace forEach with for..of in test-net-isipv6.js
niyashiyas Sep 23, 2023
2458e27
test: replace forEach with for..of in test-net-isipv6.js
niyashiyas Sep 24, 2023
51fd40e
Update test/parallel/test-net-isipv6.js
lpinca Oct 7, 2023
704b321
Update test/parallel/test-net-isipv6.js
lpinca Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/parallel/test-net-isipv6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,10 @@ const v6not = [
'02001:0000:1234:0000:0000:C1C0:ABCD:0876',
];

v6.forEach((ip) => {
for(const ip of v6) {
lpinca marked this conversation as resolved.
Show resolved Hide resolved
assert.strictEqual(net.isIPv6(ip), true);
});
}

v6not.forEach((ip) => {
for(const ip of v6not) {
lpinca marked this conversation as resolved.
Show resolved Hide resolved
assert.strictEqual(net.isIPv6(ip), false);
});
}