Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove deprecated python api #49731

Closed
wants to merge 1 commit into from
Closed

tools: remove deprecated python api #49731

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

Fixes: #49729

Upstream: python/cpython#105456

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2023
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54076/

@targos
Copy link
Member

targos commented Sep 20, 2023

Note #47005

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Open
22 tasks
This was referenced Sep 22, 2023
Open
Open
@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@himself65 himself65 force-pushed the himself65/remove-deprecated branch 2 times, most recently from e680bc1 to c3cad54 Compare October 14, 2023 22:48
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54791/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54795/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54803/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54806/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54815/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54835/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54857/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55932/

@himself65
Copy link
Member Author

I dont know why CI fails again and again🤔

@anonrig
Copy link
Member

anonrig commented Nov 27, 2023

I dont know why CI fails again and again🤔

it's a flaky test

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55945/

@himself65
Copy link
Member Author

Let me rebase to see if it helps

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56586/

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56588/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56628/

himself65 added a commit that referenced this pull request Jan 7, 2024
@himself65
tools: remove deprecated python api
921406c 
PR-URL: #49731
Fixes: #49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@himself65
Copy link
Member Author

Landed in 921406c

@himself65 himself65 closed this Jan 7, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@himself65 @marco-ippolito
tools: remove deprecated python api
c15202b 
PR-URL: nodejs#49731
Fixes: nodejs#49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@himself65 @Medhansh404
tools: remove deprecated python api
6257dc6 
PR-URL: nodejs#49731
Fixes: nodejs#49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@himself65 @targos
tools: remove deprecated python api
83b3aa8 
PR-URL: #49731
Fixes: #49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@himself65 @richardlau
tools: remove deprecated python api
78ce5a8 
PR-URL: #49731
Fixes: #49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@himself65 @richardlau
tools: remove deprecated python api
4372f6a 
PR-URL: #49731
Fixes: #49729
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
SRombauts added a commit to SRombauts/SQLiteCpp that referenced this pull request Aug 20, 2024
@SRombauts
cpplint: Fix DeprecationWarning: module 'sre_compile' is deprecated
200c236 
Same fix as nodejs/node#49731 tools: remove deprecated python api
SRombauts added a commit to SRombauts/SQLiteCpp that referenced this pull request Aug 21, 2024
@SRombauts
cpplint: Fix DeprecationWarning: module 'sre_compile' is deprecated
fd10e1a 
Same fix as nodejs/node#49731 tools: remove deprecated python api
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: module 'sre_compile' is deprecated
6 participants
@himself65 @nodejs-github-bot @targos @anonrig @lpinca @marco-ippolito