Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add common.platformTimeout() to dgram test #4938

Closed
wants to merge 1 commit into from
Closed

test: add common.platformTimeout() to dgram test #4938

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 29, 2016

Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937

@Trott Trott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Jan 29, 2016
@Trott
test: add common.platformTimeout() to dgram test
18f930c 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: nodejs#4937
@Trott
Copy link
Member Author

Trott commented Jan 29, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1424/

@cjihrig
Copy link
Contributor

cjihrig commented Jan 29, 2016

LGTM

1 similar comment
@MylesBorins
Copy link
Contributor

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 29, 2016

CI is green.

@jasnell
Copy link
Member

jasnell commented Jan 29, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jan 31, 2016
@Trott
test: add common.platformTimeout() to dgram test
d319561 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: nodejs#4937
PR-URL: nodejs#4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 31, 2016

Landed in d319561

@Trott Trott closed this Jan 31, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@Trott @rvagg
test: add common.platformTimeout() to dgram test
443d046 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937
PR-URL: #4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
@Trott
test: add common.platformTimeout() to dgram test
df9844e 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937
PR-URL: #4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
@Trott
test: add common.platformTimeout() to dgram test
226dfef 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937
PR-URL: #4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@Trott
test: add common.platformTimeout() to dgram test
edc2df9 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937
PR-URL: #4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: add common.platformTimeout() to dgram test
45ac61b 
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: nodejs#4937
PR-URL: nodejs#4938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <mborins@us.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the add-platform-timeout branch January 13, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @cjihrig @MylesBorins @jasnell