Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs : doc readdir recursive sync & callback #48640 #48902

Merged
merged 2 commits into from Oct 10, 2023
Merged

fs : doc readdir recursive sync & callback #48640 #48902

merged 2 commits into from Oct 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 24, 2023 •
edited by aduh95
Loading

Fixes: #48640

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 24, 2023
lpinca
lpinca approved these changes Jul 26, 2023
View reviewed changes
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
doc/api/fs.md Outdated Show resolved Hide resolved
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 30, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 30, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/48902
✔  Done loading data for nodejs/node/pull/48902
----------------------------------- PR info ------------------------------------
Title      fs : doc readdir recursive sync & callback #48640 (#48902)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     RamdohokarAngha:fs-doc-readdir-recursive-sync-&-callback -> nodejs:main
Labels     doc, fs, author ready, commit-queue-squash
Commits    4
 - fs : doc readdir recursive sync & callback
 - Update doc/api/fs.md
 - Update doc/api/fs.md
 - Merge branch 'nodejs:main' into fs-doc-readdir-recursive-sync-&-callback
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48902
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48902
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 24 Jul 2023 11:40:08 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48902#pullrequestreview-1548446213
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/48902#pullrequestreview-1651609728
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48902
From https://github.com/nodejs/node
 * branch                  refs/pull/48902/merge -> FETCH_HEAD
✔  Fetched commits as 51f4ff245018..e2cfe24fc05a
--------------------------------------------------------------------------------
Auto-merging doc/api/fs.md
[main 5931ae8cee] fs : doc readdir recursive sync & callback
 Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com>
 Date: Mon Jul 24 17:06:51 2023 +0530
 1 file changed, 6 insertions(+), 3 deletions(-)
Auto-merging doc/api/fs.md
[main 422bc6de18] Update doc/api/fs.md
 Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com>
 Date: Wed Aug 16 11:37:49 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging doc/api/fs.md
error: commit e2cfe24fc05a82df5feff180c6dc5296e6a6f79c is a merge but no -m option was given.
fatal: cherry-pick failed
[main 1f365ad1d5] Update doc/api/fs.md
 Author: RamdohokarAngha <91063774+RamdohokarAngha@users.noreply.github.com>
 Date: Wed Aug 16 11:38:07 2023 +0530
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/6359670729

@KuthorX
Copy link
Contributor

KuthorX commented Oct 10, 2023

associated with #48640

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 34fa704 into nodejs:main Oct 10, 2023
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 34fa704

@RafaelGSS RafaelGSS mentioned this pull request Oct 10, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@alexfernandez
doc: fix description of fs.readdir recursive option
03d138f 
PR-URL: nodejs#48902
Fixes: nodejs#48640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@targos
doc: fix description of fs.readdir recursive option
3d03ca9 
PR-URL: #48902
Fixes: #48640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@debadree25
doc: fix description of fs.readdir recursive option
0345207 
PR-URL: nodejs#48902
Fixes: nodejs#48640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.readdir's new recursive option is not fully documented
5 participants
@nodejs-github-bot @KuthorX @lpinca @anonrig @aduh95