Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change duration to duration_ms on test documentation #48892

Merged

Conversation

ardinugrxha
Copy link
Contributor

@ardinugrxha ardinugrxha commented Jul 23, 2023

change duration to duration_ms in test documentation

Fixes: #48887

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jul 23, 2023
@ardinugrxha ardinugrxha changed the title doc:change duration to duration_ns on test documentation doc:change duration to duration_ms on test documentation Jul 23, 2023
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

@ardinugrxha ardinugrxha changed the title doc:change duration to duration_ms on test documentation doc: change duration to duration_ms on test documentation Jul 23, 2023
@ardinugrxha
Copy link
Contributor Author

LGTM, thanks for the PR. There's a typo in the commit message (duration_ns -> duration_ms), and there needs to be a space after the subsystem (doc:change -> doc: change). Could you amend the commit message and force push to your branch please? I can do it for you if you prefer.

sure :)

@ardinugrxha ardinugrxha force-pushed the doc-rename-duration-to-duration_ns branch from 3afbda0 to c8faff2 Compare July 23, 2023 13:36
@koshic
Copy link

koshic commented Jul 23, 2023

@0xArdi-N plz don't forget about test:fail

@ardinugrxha
Copy link
Contributor Author

@0xArdi-N plz don't forget about test:fail

on it

@ardinugrxha ardinugrxha force-pushed the doc-rename-duration-to-duration_ns branch from c8faff2 to a20a7c8 Compare July 23, 2023 13:41
@deokjinkim
Copy link
Contributor

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

@ardinugrxha ardinugrxha force-pushed the doc-rename-duration-to-duration_ns branch from a20a7c8 to 9eca9da Compare July 23, 2023 14:24
@ardinugrxha
Copy link
Contributor Author

@0xArdi-N Thank you for contribution. Typo in commit title(duration_ns -> duration_ms) is not fixed yet. Could you please resolve this?

hi @deokjinkim , I'm already fixed that. :)

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2023
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 71165e1 into nodejs:main Jul 25, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 71165e1

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48892
Fixes: nodejs#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Oct 28, 2023
PR-URL: #48892
Fixes: #48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48892
Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#48892
Fixes: nodejs/node#48887
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_runner: incorrect test:pass & test:fail events description, 'duration' instead of 'duration_ms'
10 participants