Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: add __proto__ null #48661

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

assert: add __proto__ null #48661

wants to merge 2 commits into from

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Jul 5, 2023 •
edited
Loading

extracted from:

TODO:

  • Run CITGM
  • mark as a major change

reference: #48646 (comment)

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Jul 5, 2023
@rluvaton rluvaton changed the title assert: add __proto__ null assert: add __proto__ null Jul 5, 2023
@anonrig anonrig added the needs-benchmark-ci PR that need a benchmark CI run. label Jul 6, 2023
@anonrig
Copy link
Member

anonrig commented Jul 6, 2023

I believe we need a benchmark CI for this since its used in lots of places in Node.js.

@rluvaton
Copy link
Member Author

rluvaton commented Jul 6, 2023

you're right, Can you please trigger the benchmark CI?

@lpinca
Copy link
Member

lpinca commented Jul 12, 2023 •
edited by aduh95
Loading

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1350/

Results 
                                                                                                                      confidence improvement accuracy (*)    (**)   (***)
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=0 len=100 n=20000                                                 -0.41 %       ±1.67%  ±2.23%  ±2.90%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=0 len=1000 n=20000                                                -0.06 %       ±1.49%  ±1.99%  ±2.58%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=1 len=100 n=20000                                                 -0.19 %       ±1.10%  ±1.47%  ±1.91%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=0 strict=1 len=1000 n=20000                                                 0.25 %       ±1.54%  ±2.05%  ±2.67%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=0 len=100 n=20000                                                 -0.08 %       ±0.94%  ±1.26%  ±1.64%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=0 len=1000 n=20000                                                 0.25 %       ±1.17%  ±1.56%  ±2.03%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=1 len=100 n=20000                                                  0.26 %       ±1.55%  ±2.06%  ±2.68%
assert/deepequal-buffer.js method='deepEqual' arrayBuffer=1 strict=1 len=1000 n=20000                                                 2.29 %       ±3.24%  ±4.34%  ±5.73%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=0 strict=1 len=100 n=20000                                               0.20 %       ±1.42%  ±1.89%  ±2.46%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=0 strict=1 len=1000 n=20000                                              0.07 %       ±0.91%  ±1.21%  ±1.57%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=1 strict=1 len=100 n=20000                                              -0.72 %       ±1.64%  ±2.18%  ±2.84%
assert/deepequal-buffer.js method='notDeepEqual' arrayBuffer=1 strict=1 len=1000 n=20000                                       *      2.05 %       ±1.62%  ±2.16%  ±2.81%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=0 strict=1 len=100 n=20000                                             0.15 %       ±1.30%  ±1.74%  ±2.27%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=0 strict=1 len=1000 n=20000                                           -0.04 %       ±0.86%  ±1.15%  ±1.50%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=1 strict=1 len=100 n=20000                                            -0.25 %       ±1.31%  ±1.75%  ±2.28%
assert/deepequal-buffer.js method='unequal_length' arrayBuffer=1 strict=1 len=1000 n=20000                                            0.75 %       ±1.97%  ±2.63%  ±3.45%
assert/deepequal-map.js method='deepEqual_mixed' strict=0 len=500 n=500                                                               0.28 %       ±7.66% ±10.20% ±13.27%
assert/deepequal-map.js method='deepEqual_mixed' strict=1 len=500 n=500                                                               5.20 %      ±10.40% ±13.84% ±18.01%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                         -3.88 %       ±7.34%  ±9.77% ±12.72%
assert/deepequal-map.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                          3.42 %       ±8.55% ±11.38% ±14.82%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                      -0.76 %       ±5.71%  ±7.60%  ±9.90%
assert/deepequal-map.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                       0.65 %       ±7.92% ±10.54% ±13.72%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                           -0.35 %       ±9.19% ±12.23% ±15.92%
assert/deepequal-map.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                           -5.97 %       ±9.36% ±12.45% ±16.20%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                       4.70 %      ±10.47% ±13.93% ±18.13%
assert/deepequal-map.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                      -3.51 %       ±9.89% ±13.16% ±17.13%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                    1.22 %       ±7.25%  ±9.65% ±12.55%
assert/deepequal-map.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                    2.80 %       ±6.87%  ±9.14% ±11.90%
assert/deepequal-object.js method='deepEqual' strict=1 size=100 n=2000                                                               -1.17 %       ±2.51%  ±3.34%  ±4.34%
assert/deepequal-object.js method='deepEqual' strict=1 size=1000 n=200                                                                1.13 %       ±2.50%  ±3.33%  ±4.34%
assert/deepequal-object.js method='deepEqual' strict=1 size=10000 n=25                                                               -0.01 %       ±1.93%  ±2.57%  ±3.35%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=100 n=2000                                                            -0.78 %       ±7.78% ±10.35% ±13.48%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=1000 n=200                                                             1.46 %       ±5.88%  ±7.84% ±10.23%
assert/deepequal-object.js method='notDeepEqual' strict=1 size=10000 n=25                                                            -5.18 %       ±9.29% ±12.37% ±16.10%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='array'                                    1.68 %       ±3.56%  ±4.79%  ±6.34%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='boolean'                                  1.81 %       ±3.26%  ±4.34%  ±5.66%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='circular'                                -4.64 %       ±7.84% ±10.43% ±13.58%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='date'                                    -2.04 %       ±6.71%  ±8.92% ±11.61%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='empty_object'                            -3.66 %       ±5.82%  ±7.75% ±10.09%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='number'                                  -1.98 %       ±2.84%  ±3.78%  ±4.92%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='object_other_property'                   -1.59 %       ±2.66%  ±3.55%  ±4.63%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='object'                                  -0.07 %       ±3.11%  ±4.14%  ±5.40%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='regexp'                                   1.38 %       ±7.68% ±10.22% ±13.30%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='set_object'                               0.56 %       ±5.29%  ±7.04%  ±9.16%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='set_simple'                               2.86 %       ±9.30% ±12.37% ±16.10%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=0 n=100000 primitive='string'                                  -0.81 %       ±2.73%  ±3.64%  ±4.75%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='array'                                    1.15 %       ±4.24%  ±5.68%  ±7.46%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='boolean'                                 -2.34 %       ±2.96%  ±3.94%  ±5.13%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='circular'                                 8.81 %      ±10.71% ±14.26% ±18.56%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='date'                                    -3.96 %       ±9.81% ±13.06% ±17.00%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='empty_object'                            -7.14 %       ±9.35% ±12.44% ±16.20%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='number'                                  -0.67 %       ±3.02%  ±4.01%  ±5.22%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='object_other_property'                   -2.08 %       ±2.69%  ±3.59%  ±4.67%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='object'                                   1.49 %       ±5.16%  ±6.88%  ±8.97%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='regexp'                                  -4.96 %       ±9.73% ±12.95% ±16.86%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='set_object'                              -1.05 %       ±7.98% ±10.62% ±13.83%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='set_simple'                               4.25 %      ±10.13% ±13.48% ±17.54%
assert/deepequal-prims-and-objs-big-loop.js method='deepEqual' strict=1 n=100000 primitive='string'                                  -0.59 %       ±3.02%  ±4.02%  ±5.24%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='array'                                 3.07 %       ±6.37%  ±8.49% ±11.06%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='boolean'                               0.59 %       ±2.69%  ±3.57%  ±4.65%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='circular'                             -5.35 %       ±9.77% ±13.00% ±16.92%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='date'                                 -4.48 %       ±7.02%  ±9.34% ±12.16%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='empty_object'                         -4.01 %       ±5.64%  ±7.51%  ±9.78%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='number'                               -1.70 %       ±2.71%  ±3.61%  ±4.70%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='object_other_property'                -0.91 %       ±2.75%  ±3.67%  ±4.78%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='object'                                0.10 %       ±1.05%  ±1.40%  ±1.82%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='regexp'                        **    -10.47 %       ±6.98%  ±9.31% ±12.16%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='set_object'                            1.94 %      ±10.68% ±14.21% ±18.49%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='set_simple'                            2.69 %      ±10.38% ±13.81% ±17.98%
assert/deepequal-prims-and-objs-big-loop.js method='notDeepEqual' strict=1 n=100000 primitive='string'                               -1.41 %       ±2.49%  ±3.31%  ±4.32%
assert/deepequal-set.js method='deepEqual_mixed' strict=0 len=500 n=500                                                               0.64 %      ±10.55% ±14.03% ±18.27%
assert/deepequal-set.js method='deepEqual_mixed' strict=1 len=500 n=500                                                              -1.78 %       ±9.68% ±12.88% ±16.77%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=0 len=500 n=500                                                          0.05 %       ±6.59%  ±8.76% ±11.41%
assert/deepequal-set.js method='deepEqual_objectOnly' strict=1 len=500 n=500                                                         -1.33 %       ±8.61% ±11.45% ±14.91%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=0 len=500 n=500                                                      -4.35 %       ±5.64%  ±7.52%  ±9.81%
assert/deepequal-set.js method='deepEqual_primitiveOnly' strict=1 len=500 n=500                                                       6.32 %       ±7.68% ±10.22% ±13.32%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=0 len=500 n=500                                                           -0.53 %      ±10.45% ±13.90% ±18.09%
assert/deepequal-set.js method='notDeepEqual_mixed' strict=1 len=500 n=500                                                            2.10 %      ±10.66% ±14.19% ±18.48%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=0 len=500 n=500                                                *     10.40 %      ±10.29% ±13.69% ±17.82%
assert/deepequal-set.js method='notDeepEqual_objectOnly' strict=1 len=500 n=500                                                      -6.02 %       ±9.79% ±13.02% ±16.95%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=0 len=500 n=500                                                    0.72 %       ±6.86%  ±9.13% ±11.88%
assert/deepequal-set.js method='notDeepEqual_primitiveOnly' strict=1 len=500 n=500                                                   -1.66 %       ±6.99%  ±9.31% ±12.12%
assert/deepequal-simple-array-and-set.js method='deepEqual_Array' strict=1 len=10000 n=500                                     *     -9.88 %       ±7.66% ±10.23% ±13.39%
assert/deepequal-simple-array-and-set.js method='deepEqual_Set' strict=1 len=10000 n=500                                             -6.52 %       ±8.72% ±11.61% ±15.11%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Array' strict=1 len=10000 n=500                                         6.55 %       ±9.93% ±13.21% ±17.20%
assert/deepequal-simple-array-and-set.js method='notDeepEqual_Set' strict=1 len=10000 n=500                                           4.18 %       ±9.64% ±12.82% ±16.69%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Float32Array'                                 **     -2.73 %       ±1.68%  ±2.23%  ±2.91%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Int8Array'                                           -1.19 %       ±5.21%  ±6.94%  ±9.04%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint32Array'                                         -5.61 %       ±8.13% ±10.83% ±14.13%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=0 n=500 type='Uint8Array'                                           1.06 %       ±7.74% ±10.30% ±13.41%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Float32Array'                                         1.61 %       ±6.65%  ±8.86% ±11.54%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Int8Array'                                           -2.91 %       ±5.82%  ±7.76% ±10.11%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint32Array'                                          4.10 %       ±8.13% ±10.81% ±14.08%
assert/deepequal-typedarrays.js len=100 method='deepEqual' strict=1 n=500 type='Uint8Array'                                           1.24 %       ±6.40%  ±8.52% ±11.09%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                     -0.38 %       ±6.02%  ±8.00% ±10.42%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                        -0.72 %       ±7.78% ±10.36% ±13.49%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint32Array'                                      -6.75 %      ±12.05% ±16.03% ±20.87%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                        3.29 %       ±8.89% ±11.82% ±15.39%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                     -4.67 %      ±14.44% ±19.23% ±25.04%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                        -2.35 %      ±10.58% ±14.08% ±18.32%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint32Array'                                      -2.59 %      ±11.38% ±15.14% ±19.70%
assert/deepequal-typedarrays.js len=100 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                       -5.51 %       ±7.32%  ±9.74% ±12.69%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Float32Array'                                       -4.01 %       ±4.03%  ±5.37%  ±6.98%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Int8Array'                                          -2.65 %       ±5.38%  ±7.16%  ±9.34%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint32Array'                                         2.56 %       ±8.29% ±11.03% ±14.37%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=0 n=500 type='Uint8Array'                                         -1.72 %       ±6.01%  ±8.00% ±10.42%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Float32Array'                                **     10.08 %       ±7.51% ±10.02% ±13.12%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Int8Array'                                          -0.57 %       ±5.84%  ±7.77% ±10.12%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint32Array'                                        -1.47 %       ±7.31%  ±9.73% ±12.67%
assert/deepequal-typedarrays.js len=5000 method='deepEqual' strict=1 n=500 type='Uint8Array'                                         -0.49 %       ±5.61%  ±7.47%  ±9.72%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Float32Array'                                     5.35 %       ±9.57% ±12.74% ±16.59%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Int8Array'                                        6.45 %      ±11.14% ±14.83% ±19.32%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint32Array'                                      4.32 %      ±10.54% ±14.06% ±18.36%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=0 n=500 type='Uint8Array'                                       2.97 %       ±8.92% ±11.87% ±15.45%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Float32Array'                                    -1.44 %      ±12.02% ±15.99% ±20.82%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Int8Array'                                 *     -8.53 %       ±8.12% ±10.82% ±14.11%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint32Array'                                      3.19 %      ±10.46% ±13.94% ±18.18%
assert/deepequal-typedarrays.js len=5000 method='notDeepEqual' strict=1 n=500 type='Uint8Array'                                       2.47 %       ±9.45% ±12.58% ±16.37%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 118 comparisons, you can thus
expect the following amount of false-positive results:
  5.90 false positives, when considering a   5% risk acceptance (*, **, ***),
  1.18 false positives, when considering a   1% risk acceptance (**, ***),
  0.12 false positives, when considering a 0.1% risk acceptance (***)

@rluvaton
Copy link
Member Author

Thanks @lpinca what do you think about the results?

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 16, 2023
@anonrig
Copy link
Member

anonrig commented Jul 16, 2023

It seems we only have a benchmark for deepequal which is a small fraction of what assert provides. Before merging this in, I think we need more benchmarks on assert

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52776/

@RedYetiDev
Copy link
Member

Hi! It's been a little while since this PR was last updated. Currently, it's in the squash queue, but not the commit queue. If you wish to pursue this further, I suggest verifying that it is still applicable/viable now, and having the team perform some reviews.

Thank you!

This is an attempt to resolve older PRs

@nodejs/assert

anonrig
anonrig requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should properly benchmark these changes. I'm requesting changes since this PR can land right now without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig requested changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rluvaton @anonrig @lpinca @nodejs-github-bot @RedYetiDev @jasnell