Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: separate RegExp benchmark from v8 basic bench #482

Closed
wants to merge 1 commit into from
Closed

benchmark: separate RegExp benchmark from v8 basic bench #482

wants to merge 1 commit into from

Conversation

yosuke-furukawa
Copy link
Member

RegExp bench is separated from run.js. And I created runRegExp.js for running another contexts.

RegExp bench creates global RegExp (https://github.com/iojs/io.js/blob/v1.x/deps/v8/benchmarks/regexp.js#L40).
However, the RegExp causes a error. The detail is here.

#475

@bnoordhuis
Copy link
Member

Thanks for bringing that up, @yosuke-furukawa. I suggested an alternative approach in #489 (and I'd like you to review it, if you don't mind) because I'd rather not touch files in the deps/ directory.

@cjihrig
Copy link
Contributor

cjihrig commented Jan 18, 2015

Closing in favor of #489 since @yosuke-furukawa LGTM'ed it.

@cjihrig cjihrig closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants