Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.5.0 Release Proposal (Stable) #4742

Merged
merged 33 commits into from
Jan 21, 2016
Merged

v5.5.0 Release Proposal (Stable) #4742

merged 33 commits into from
Jan 21, 2016

Commits on Jan 18, 2016

  1. build: add option to select VS version

    This changes vcbuild.bat to accept a new parameter (vc2015 or vc2013)
    to select the version of Visual Studio to use.
    
    PR-URL: #4645
    Reviewed-By: João Reis <reis@janeasystems.com>
    greenjava authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    fe5b710 View commit details
    Browse the repository at this point in the history
  2. crypto: clear error stack in ECDH::Initialize

    Clean up OpenSSL error stack in `ECDH::Initialize`, some curves have
    faulty implementations that are leaving dangling errors after
    initializing the curve.
    
    Fix: #4686
    PR-URL: #4689
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    indutny authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    8bf5b33 View commit details
    Browse the repository at this point in the history
  3. debugger: remove variable redeclarations

    Some variables are declared with var more than once in the same scope.
    This change reduces the declarations to one per scope.
    
    PR-URL: #4633
    Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Trott authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    0d0a5ed View commit details
    Browse the repository at this point in the history
  4. doc: clarify protocol default in http.request()

    The previously listed default of 'http' is incorrect, and
    causes an error to be thrown. This commit changes it to the
    correct value of 'http:'
    
    Fixes: #4712
    PR-URL: #4714
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    dcaf6fd View commit details
    Browse the repository at this point in the history
  5. doc: update branch-diff arguments in release doc

    PR-URL: #4691
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    rvagg authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    43dfd03 View commit details
    Browse the repository at this point in the history
  6. doc: fix named anchors in addons.markdown and http.markdown

    PR-URL: #4708
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MichaelTheriot authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    01bdafe View commit details
    Browse the repository at this point in the history
  7. doc: add path property to Write/ReadStream in fs.markdown

    Documents the "path" property on fs.WriteStream
    and fs.ReadStream. See #4327
    
    PR-URL: #4368
    Reviewed-By: James M Snell <jasnell@gmail.com>
    claudiorodriguez authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    a6c242f View commit details
    Browse the repository at this point in the history
  8. doc: clarify explanation of first stream section

    The last sentence of the explanation for the first stream section
    seemed a bit confusing. I tried to change the sentence to clarify it.
    
    Additionally, the sections were turned into a numbered list to be more
    clear about which section is being described, and improve readability.
    
    PR-URL: #4234
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vccortez authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    056b078 View commit details
    Browse the repository at this point in the history
  9. events: make sure console functions exist

    If there's no global console cached, initialize it.
    
    Fixes: #4467
    PR-URL: #4479
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Dave authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    a8330f7 View commit details
    Browse the repository at this point in the history
  10. fs: add autoClose option to fs.createWriteStream

    Add support to fs.createWriteStream and fs.createWriteStream for an autoClose
    option that behaves similarly to the autoClose option supported by
    fs.createReadStream and fs.ReadStream.
    
    When an instance of fs.createWriteStream created with autoClose === false finishes,
    it is not destroyed. Its underlying fd is not closed and it is the
    responsibility of the user to close it.
    
    PR-URL: #3679
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    saquibkhan authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    2879395 View commit details
    Browse the repository at this point in the history
  11. http: improves expect header handling

    Now returns a 417 error status or allows for an event listener on
    the `checkExpectation` event. Before we were ignoring requests that
    had misspelled `100-continue` values for expect headers.
    
    This is a quick port of the work done here:
    nodejs/node-v0.x-archive#7132 by alFReD-NSH
    with surrounding discussion here:
    nodejs/node-v0.x-archive#4651
    
    Also updates all the instances of the deprecated
    EventEmitter.listenerCount to the current self.listenerCount. Most
    of these were in the new code ported over but there was another
    legacy instance.
    
    Refs: #2403
    PR-URL: #4501
    Reviewed-By: James M Snell <jasnell@gmail.com>
    designfrontier authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    c171294 View commit details
    Browse the repository at this point in the history
  12. tools: enable no-extra-semi rule in eslint

    PR-URL: #2205
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    targos authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    16ef250 View commit details
    Browse the repository at this point in the history
  13. lib,test: remove extra semicolons

    PR-URL: #2205
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    targos authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    f0ee088 View commit details
    Browse the repository at this point in the history
  14. querystring: improve parse() performance

    These changes improve parse() performance from ~11-30% on all of
    the existing querystring benchmarks.
    
    PR-URL: #4675
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mscdex authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    c6ac464 View commit details
    Browse the repository at this point in the history
  15. repl: make sure historyPath is trimmed

    If one were to set NODE_REPL_HISTORY to a string that contains only a
    space (" "), then the history file would be created with that name
    which can cause problems are certain systems.
    
    PR-URL: #4539
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    8104d9d View commit details
    Browse the repository at this point in the history
  16. src: don't check failure with ERR_peek_error()

    It's possible there is already an existing error on OpenSSL's error
    stack that is unrelated to the EVP_DigestInit_ex() operation we just
    executed.
    
    Fixes: #4221
    PR-URL: #4731
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    bnoordhuis authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    6988d2e View commit details
    Browse the repository at this point in the history
  17. node: allow preload modules with -i

    This gives us the ability to preload when using the node repl. This can
    be useful for doing things like creating aliases.
    
    Fixes: #4661
    PR-URL: #4696
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    848b04b View commit details
    Browse the repository at this point in the history
  18. v8,src: expose statistics about heap spaces

    Provide means to inspect information about the separate heap spaces
    via a callable API. This is helpful to analyze memory issues.
    
    Fixes: #2079
    PR-URL: #4463
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bripkens authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    4254508 View commit details
    Browse the repository at this point in the history
  19. buffer: make byteLength work with Buffer correctly

    Make the byteLength work correctly when input is Buffer.
    
    e.g:
    
    ```js
    // The incomplete unicode string
    Buffer.byteLength(new Buffer([0xe4, 0xb8, 0xad, 0xe6, 0x96]))
    ```
    The old output: 9
    The new output: 5
    
    PR-URL: #4738
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    JacksonTian authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    f221a43 View commit details
    Browse the repository at this point in the history
  20. readline: Remove XXX and output debuglog

    Remove a comment that has a word 'XXX'.
    And add a line to output debuglog of error.
    
    PR-URL: #4690
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    kohei-takata authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    d533364 View commit details
    Browse the repository at this point in the history
  21. src: return UV_EAI_NODATA on empty lookup

    AfterGetAddrInfo() can potentially return an empty array of
    results without setting an error value. The JavaScript layer
    expects the array to have at least one value if an error is
    not returned. This commit sets a UV_EAI_NODATA error when an
    empty result array is detected.
    
    Fixes: #4545
    PR-URL: #4715
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    cjihrig authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    3af206d View commit details
    Browse the repository at this point in the history
  22. test: fix tls-multi-key race condition

    In some conditions it can happen that the client-side socket is
    destroyed before the server-side socket has gracefully closed, thus
    causing a 'ECONNRESET' error in this socket. To solve this, also close
    gracefully in the client side.
    
    PR-URL: #3966
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    santigimeno authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    399db04 View commit details
    Browse the repository at this point in the history
  23. buffer: remove unnecessary TODO comments

    Refs: #4642
    PR-URL: #4719
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    pgeiss authored and evanlucas committed Jan 18, 2016
    Configuration menu
    Copy the full SHA
    14061c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2016

  1. module: cache stat() results more aggressively

    Reduce the number of stat() system calls that require() makes by caching
    the results more aggressively.
    
    To avoid unbounded growth without implementing a LRU cache, scope the
    cache to the lifetime of the first call to require().  Recursive calls
    (i.e. require() calls in the included code) transparently profit from
    the cache.
    
    The benchmarked application is the loopback-sample-app[0] and it sees
    the number of stat calls at start-up go down by 40%, from 4736 to 2810.
    
    [0] https://github.com/strongloop/loopback-sample-app
    
    PR-URL: #4575
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bnoordhuis authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    eb2b8c6 View commit details
    Browse the repository at this point in the history
  2. tools: enable space-in-parens ESLint rule

    Ref: http://eslint.org/docs/rules/space-in-parens.html
    PR-URL: #4753
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    silverwind authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    8f4f5b3 View commit details
    Browse the repository at this point in the history
  3. test: fix issues for space-in-parens ESLint rule

    PR-URL: #4753
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    silverwind authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    a39b28b View commit details
    Browse the repository at this point in the history
  4. test: make test-cluster-disconnect-leak reliable

    Previously, test-cluster-disconnect-leak had two issues:
    
    * Magic numbers: How many times to spawn a worker was determined through
    empirical experimentation. This means that as new platforms and new
    CPU/RAM configurations are tested, the magic numbers require more
    and more refinement. This brings us to...
    
    * Non-determinism: The test *seems* to fail all the time when the bug
    it tests for is present, but it's really a judgment based on sampling.
    "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try
    16..."
    
    This revised version of the test takes a different approach. The fix
    for the bug that the test was written for means that the `disconnect`
    event will fire reliably for a single worker. So we check for that and
    the test still fails when the fix is not in the code base and succeeds
    when it is.
    
    Advantages of this approach include:
    
    * The test runs much faster.
    * The test now works on Windows. The previous version skipped Windows.
    * The test should be reliable on any new platform regardless of CPU and
    RAM.
    
    Ref: #4674
    
    PR-URL: #4736
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    a347cd7 View commit details
    Browse the repository at this point in the history
  5. stream: prevent object map change in ReadableState

    ReadableState has the resumeScheduled property that helps determine if
    a stream should be resumed. It was not assigned in the constructor.
    When stream.resume is called on a readable stream that is not flowing,
    it is set to true. This changes the property map of the ReadableState
    which can cause a deopt in onEofChunk and needMoreData.
    
    PR-URL: #4761
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    426ff82 View commit details
    Browse the repository at this point in the history
  6. doc: restore ICU third-party software licenses

    PR-URL: #4762
    Reviewed-By: Rod Vagg <rod@vagg.org>
    richardlau authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    8a11b8c View commit details
    Browse the repository at this point in the history
  7. tools: fix license-builder.sh for ICU

    Modify tools/license-builder.sh to restore the Third-Party Software
    licenses for ICU.
    
    Also fix arguments to tail to work on Linux.
    
    rvagg: modified sed command for ICU to replace tabs with spaces and
           remove whitespace at the end of lines
    
    PR-URL: #4762
    Reviewed-By: Rod Vagg <rod@vagg.org>
    richardlau authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    fe23f42 View commit details
    Browse the repository at this point in the history
  8. src: fix negative values in process.hrtime()

    Fix a regression introduced in commit 89f056b ("node: improve
    performance of hrtime()") where the nanosecond field sometimes
    had a negative value when calculating the difference between two
    timestamps.
    
    Fixes: #4751
    PR-URL: #4757
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    bnoordhuis authored and evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    a2c257a View commit details
    Browse the repository at this point in the history
  9. 2016-01-20, Version 5.5.0 (Stable)

    Notable changes:
    
    * events: make sure console functions exist (Dave) #4479
    * fs: add autoClose option to fs.createWriteStream (Saquib) #3679
    * http: improves expect header handling (Daniel Sellers) #4501
    * node: allow preload modules with -i (Evan Lucas) #4696
    * v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) #4463
    * Minor performance improvements:
      - lib: Use arrow functions instead of bind where possible (Minwoo Jung) #3622
      - module: cache stat() results more aggressively (Ben Noordhuis) #4575
      - querystring: improve parse() performance (Brian White) #4675
    
    PR-URL: #4742
    evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    dd88256 View commit details
    Browse the repository at this point in the history
  10. Working on v5.5.1

    PR-URL: #4742
    evanlucas committed Jan 20, 2016
    Configuration menu
    Copy the full SHA
    2d46ea0 View commit details
    Browse the repository at this point in the history